- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.2k
Closed
Labels
arch-wasmWebAssembly architectureWebAssembly architecturearea-Debugger-monoenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additions
Milestone
Description
We do not have a mechanism of detecting if literal is short, so both options from each case:
- short and int
- sbyte and byte
- uint and ushort
 are falling into the non-short category inMonoSdbHelper.WriteNumbers. The simplest fix for it that comes to my mind is a mechanism ofInvokeMethodretries every time we detect a numeric literal that is of type int/byte/uint. With multiple parameters that classify for retry, the number of retries grows exponentially which is not the best solution.
Uncomment
// ("test.SumDefaultNegativeAndRequiredParamShortInts(-1, -120)", TNumber(-121)),
// ("test.SumDefaultNegativeAndRequiredParamShortInts(-1)", TNumber(-124)), // default: -123
// ("test.GetDefaultNegativeShortInt(-123)", TNumber(-123)),
in EvaluateMethodWithDefaultParam test. Current behavior:
"No implementation of method 'GetDefaultNegativeShortInt' matching 'test.GetDefaultNegativeShortInt(-123)' found in type DebuggerTests.DefaultParamMethods.TestClass.",
Metadata
Metadata
Assignees
Labels
arch-wasmWebAssembly architectureWebAssembly architecturearea-Debugger-monoenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additions
