get attributes from objects created on runtime

[ehsangfl]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Runtimebject.GetType().GetProperty("prop1").GetCustomAttributes() raised an error when the runtime object was created through System.Reflection.Emit.TypeBuilder

platform: Blazor wasm
version: 7.0.8
browser: Chrome

Expected Behavior

Runtimebject.GetType().GetProperty("prop1").GetCustomAttributes() return a list of attributes contains Display and Required attribute

Steps To Reproduce

I created a type through System.Reflection.Emit.TypeBuilder and named it RutimeObject

then I added a property named prope1. then add some attributes to the prop1 (Display and Required attributes)
then I create an instance from RuntimeObject
when I try to get custom attributes through reflection
Runtimebject.GetType().GetProperty("prop1").GetCustomAttributes();

this has not happened if you add only one attribute and it happened if add 2 or more attributes

Exceptions (if any)

dotnet.7.0.7.d6ly7i5yxa.js:5  Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/assembly.c:735, condition `<disabled>' not met

    at xe (dotnet.7.0.7.d6ly7i5yxa.js:5:509)
    at Object.je (dotnet.7.0.7.d6ly7i5yxa.js:5:792)
    at _mono_wasm_trace_logger (dotnet.7.0.7.d6ly7i5yxa.js:14:104923)
    at 00993286:0x9bf7
    at 00993286:0xa5a65
    at 00993286:0x1c0037
    at 00993286:0x1c00c6
    at 00993286:0x1c0109
    at 00993286:0x1c00dc
    at 00993286:0x33f41

.NET Version

8.0.100-preview.3.23178.7

Anything else?

No response

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Runtimebject.GetType().GetProperty("prop1").GetCustomAttributes() raised an error when the runtime object was created through System.Reflection.Emit.TypeBuilder

platform: Blazor wasm
version: 7.0.8
browser: Chrome

Expected Behavior

Runtimebject.GetType().GetProperty("prop1").GetCustomAttributes() return a list of attributes contains Display and Required attribute

Steps To Reproduce

I created a type through System.Reflection.Emit.TypeBuilder and named it RutimeObject

then I added a property named prope1. then add some attributes to the prop1 (Display and Required attributes)
then I create an instance from RuntimeObject
when I try to get custom attributes through reflection
Runtimebject.GetType().GetProperty("prop1").GetCustomAttributes();

this has not happened if you add only one attribute and it happened if add 2 or more attributes

Exceptions (if any)

dotnet.7.0.7.d6ly7i5yxa.js:5  Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/assembly.c:735, condition `<disabled>' not met

    at xe (dotnet.7.0.7.d6ly7i5yxa.js:5:509)
    at Object.je (dotnet.7.0.7.d6ly7i5yxa.js:5:792)
    at _mono_wasm_trace_logger (dotnet.7.0.7.d6ly7i5yxa.js:14:104923)
    at 00993286:0x9bf7
    at 00993286:0xa5a65
    at 00993286:0x1c0037
    at 00993286:0x1c00c6
    at 00993286:0x1c0109
    at 00993286:0x1c00dc
    at 00993286:0x33f41

.NET Version

8.0.100-preview.3.23178.7

Anything else?

No response

Author:	ehsangfl
Assignees:	-
Labels:	area-System.Reflection
Milestone:	-

[ehsangfl]

a sample

var an = new AssemblyName { Name = "TempAssembly" ,Version = new Version(1, 0, 0, 0) };
            var assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(an, AssemblyBuilderAccess.Run);
            var moduleBuilder = assemblyBuilder.DefineDynamicModule("TempWorkflowAssembly.dll");
            var tb = moduleBuilder.DefineType("namespace.myclass"
                                            , TypeAttributes.Public |
                                            TypeAttributes.Class |
                                            TypeAttributes.AnsiClass |
                                            TypeAttributes.BeforeFieldInit
                                            , typeof(Entity));

            FieldBuilder fb = tb.DefineField("_prop1",
                                                        typeof(string),
                                                        FieldAttributes.Private);

            var pb = tb.DefineProperty("prop1", PropertyAttributes.HasDefault, typeof(string), null);
            MethodAttributes getSetAttr =
           MethodAttributes.Public | MethodAttributes.SpecialName |
               MethodAttributes.HideBySig;

            // Define the "get" accessor method for prop1.
            MethodBuilder custNameGetPropMthdBldr =
                tb.DefineMethod("get_prop1",
                                           getSetAttr,
                                           typeof(string),
                                           Type.EmptyTypes);

            ILGenerator custNameGetIL = custNameGetPropMthdBldr.GetILGenerator();

            custNameGetIL.Emit(OpCodes.Ldarg_0);
            custNameGetIL.Emit(OpCodes.Ldfld, fb);
            custNameGetIL.Emit(OpCodes.Ret);

            // Define the "set" accessor method for prop1.
            MethodBuilder custNameSetPropMthdBldr =
                tb.DefineMethod("set_prop1",
                                           getSetAttr,
                                           null,
                                           new Type[] { typeof(string) });

            ILGenerator custNameSetIL = custNameSetPropMthdBldr.GetILGenerator();

            custNameSetIL.Emit(OpCodes.Ldarg_0);
            custNameSetIL.Emit(OpCodes.Ldarg_1);
            custNameSetIL.Emit(OpCodes.Stfld, fb);
            custNameSetIL.Emit(OpCodes.Ret);

            // Last, we must map the two methods created above to our PropertyBuilder to
            // their corresponding behaviors, "get" and "set" respectively.
            pb.SetGetMethod(custNameGetPropMthdBldr);
            pb.SetSetMethod(custNameSetPropMthdBldr);


            ///create display attribute
            var dat = typeof(DisplayAttribute);
            CustomAttributeBuilder CAB = new CustomAttributeBuilder(dat.GetConstructor(new Type[0]), 
                new object[0],
                new PropertyInfo[1] { dat.GetProperty(nameof(DisplayAttribute.Name))}, 
                new object[] { "property 1"});
            pb.SetCustomAttribute(CAB);

            //create required attribute
            var rat = typeof(RequiredAttribute);
            CustomAttributeBuilder CABR = new CustomAttributeBuilder(rat.GetConstructor(new Type[0]),
                                new object[0],
                                new PropertyInfo[2] { rat.GetProperty(nameof(RequiredAttribute.ErrorMessageResourceType)),rat.GetProperty(nameof(RequiredAttribute.ErrorMessageResourceName))},
                                new object[] {typeof(MyResources.ValidationErrors), "ObjectRequired" });
            pb.SetCustomAttribute(CABR);

            var objectType = tb.CreateType();
            var instance = (Entity)Activator.CreateInstance(objectType);

I found that this is happened if we use resources for attributes

[lambdageek]

Note: that's RequiredAttribute from System.ComponentModel.DataAnnotations not System.Runtime.CompilerServices.

[lambdageek]

This should be reproducible in a console app with <UseMonoRuntime>true</UseMonoRuntime> + <SelfContained>true</SelfContained>