[NativeAOT] Test failures in System.Net.Http.Json.Unit.Tests

[VSadov]

Example: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-85694-merge-ac99d648a653499ba7/System.Net.Http.Json.Unit.Tests/3/console.8bd3fbc0.log?helixlogtype=result

Failures look like:

Running assembly:System.Net.Http.Json.Unit.Tests, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
[FAIL] System.Net.Http.Json.Functional.Tests.TranscodingWriteStreamTest.WriteAsync_Works_WhenOutputIs_WesternEuropeanEncoding(message: "Hello world")
System.NotSupportedException : JsonTypeInfo metadata for type 'System.Net.Http.Json.Functional.Tests.TranscodingWriteStreamTest+TestModel' was not provided by TypeInfoResolver of type '[]'. If using source generation, ensure that all root types passed to the serializer have been annotated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
   at System.Text.Json.ThrowHelper.ThrowNotSupportedException_NoMetadataForType(Type, IJsonTypeInfoResolver) + 0x78
   at System.Text.Json.JsonSerializerOptions.GetTypeInfoInternal(Type, Boolean, Nullable`1, Boolean, Boolean) + 0xdc
   at System.Text.Json.JsonSerializerOptions.GetTypeInfoForRootType(Type, Boolean) + 0x68
   at System.Net.Http.Json.Functional.Tests.TranscodingWriteStreamTest.<WriteAsyncTest>d__8.MoveNext() + 0x150
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x24
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xfc
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x68
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x24
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xfc
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x68
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x24
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xfc
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x68
[FAIL] System.Net.Http.Json.Functional.Tests.TranscodingWriteStreamTest.WriteAsync_Works_WhenOutputIs_WesternEuropeanEncoding(message: "ABABABABABABABABABABABABABABABABABABABABABABABABAB"...)
System.NotSupportedException : JsonTypeInfo metadata for type 'System.Net.Http.Json.Functional.Tests.TranscodingWriteStreamTest+TestModel' was not provided by TypeInfoResolver of type '[]'. If using source generation, ensure that all root types passed to the serializer have been annotated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
   at System.Text.Json.ThrowHelper.ThrowNotSupportedException_NoMetadataForType(Type, IJsonTypeInfoResolver) + 0x78
   at System.Text.Json.JsonSerializerOptions.GetTypeInfoInternal(Type, Boolean, Nullable`1, Boolean, Boolean) + 0xdc
   at System.Text.Json.JsonSerializerOptions.GetTypeInfoForRootType(Type, Boolean) + 0x68
   at System.Net.Http.Json.Functional.Tests.TranscodingWriteStreamTest.<WriteAsyncTest>d__8.MoveNext() + 0x150
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x24
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xfc
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x68
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x24
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xfc
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x68
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x24
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xfc
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x68

Steps to repro:

build.cmd -s clr.aot+libs -rc checked -c Release
cd src\libraries\System.Net.Http.Json\tests\UnitTests
..\..\..\..\..\dotnet.cmd build /t:Test -c Release /p:TestNativeAot=true /p:CoreCLRConfiguration=checked

[VSadov]

@MihaZupan @antonfirsov - Do you know of any recent test changes that could have caused this?

[MihaZupan]

No, nothing on the networking side. This looks to me like something went wrong with Json.

[MihaZupan]

cc: @dotnet/area-system-text-json

[ericstj]

I don't see where these tests enable the source generator: https://github.com/dotnet/runtime/tree/main/src/libraries/System.Net.Http.Json/tests/UnitTests

Has this ever worked @VSadov or are you trying something new?

[VSadov]

Has this ever worked @VSadov or are you trying something new?

I have just run the runtime-extra-platforms with a dummy no-op change to see whether tests are passing.
(sometimes it is a good idea before trying this with actual changes, so I'd know which breaks are mine).

The test run (#85694) is failing on some NativeAOT tests. I am logging issues on the failures as we need the tests to pass, one way or another.

I believe runtime-extra-platforms was not failing any tests on NativeAOT relatively recently (maybe a few weeks ago - not sure exactly), so this looks new.

[VSadov]

I do not see these failures in #84566 , for example, but that was in May.

I think runtime-extra-platforms runs post-merge or at least daily, so maybe there is a way to get history of failures for runtime-extra-platforms and tell more precisely when this failure first occurred.

[MichalStrehovsky]

Bunch of System.Text.Json-based test started failing at the same time. That was tracked in #88982 that was fixed yesterday. Might be worth retrying if your run didn't have the fix.

Cc @eiriktsarpalis

[VSadov]

I still see the issue locally - with the provided repro.
I've restarted testing in #85694 to pick the latest bits, but I think good chance the bug is still there (since I see it locally).

[VSadov]

The issue is definitely still there.
See, for example: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-85694-merge-f1e9e7bcbc4b4a2b8e/System.Net.Http.Json.Unit.Tests/2/console.7847c938.log?helixlogtype=result

[MichalStrehovsky]

@VSadov Could you ActiveIssue them so that we can get extra-platforms clean?

@eiriktsarpalis do you know how the fix for those looks like? It's the same failure mode as S.T.Json tests that started happening around the same time.