-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider getting rid of DumpNativeResources task #79634
Comments
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThis task extracts native resources from the input assembly and puts them into a res file. We then pass the res file to the linker. Looks like linker then runs cvres to convert it to an object file. We could just dump the resources into the object file the AOT compiler is generating and get rid of the step. Motivated by a report of:
|
|
Fixes #79634. To generate Win32 resources, we'd first use an MSBuild task to dump Win32 resources from the input IL module into a `.res` file. We'd then pass the `.res` file to link.exe. Link.exe would then invoke cvtres.exe to convert the `.res` file to `.obj`. Link.exe then links the `.obj` into the final executable. Skip all of this and instead generate the correct object data in the compiler directly. I'm reusing Win32 resource emission logic from crossgen2. It already mostly does the right thing - we just needed to split the `.rsrc` section into `.rsrc$01` and `.rsrc$02` that link.exe expects. The first part has the data directory. The second part has the actual resource data. Contributes to #73931. The cvtres step was actually non-deterministic because it creates an object file in TEMP and embeds this temporary name into the object.
This task extracts native resources from the input assembly and puts them into a res file. We then pass the res file to the linker.
Looks like linker then runs cvtres to convert it to an object file. We could just dump the resources into the object file the AOT compiler is generating and get rid of the step.
Motivated by a report of:
The text was updated successfully, but these errors were encountered: