Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoreCLR 7.0 have changed public Debug API. Why? #76960

Closed
viewizard opened this issue Oct 12, 2022 · 3 comments · Fixed by #76966
Closed

CoreCLR 7.0 have changed public Debug API. Why? #76960

viewizard opened this issue Oct 12, 2022 · 3 comments · Fixed by #76966
Labels
area-Diagnostics-coreclr
Milestone
7.0.x

Comments

@viewizard
Copy link
Member

viewizard commented Oct 12, 2022 •
edited
Loading

Hello,

could you please clarify, why in 3ea30ed
public Debug API was changed:

ICorDebugArrayValue::GetBaseIndicies https://learn.microsoft.com/en-us/dotnet/framework/unmanaged-api/debugging/icordebugarrayvalue-getbaseindicies-method?view=aspnetcore-2.1
was changed from GetBaseIndicies to GetBaseIndices

ICorDebugArrayValue::HasBaseIndicies https://learn.microsoft.com/en-us/dotnet/framework/unmanaged-api/debugging/icordebugarrayvalue-hasbaseindicies-method?view=aspnetcore-2.1
was changed from HasBaseIndicies to HasBaseIndices

CC @alpencolt @jkotas
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 12, 2022
@ghost
Copy link

ghost commented Oct 12, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Hello,

could you please clarify, why in 3ea30ed
public Debug API was changed:

ICorDebugArrayValue::GetBaseIndicies https://learn.microsoft.com/en-us/dotnet/framework/unmanaged-api/debugging/icordebugarrayvalue-getbaseindicies-method?view=aspnetcore-2.1
was changed from GetBaseIndicies to GetBaseIndices

ICorDebugArrayValue::HasBaseIndicies https://learn.microsoft.com/en-us/dotnet/framework/unmanaged-api/debugging/icordebugarrayvalue-hasbaseindicies-method?view=aspnetcore-2.1
was changed from GetBaseIndicies to GetBaseIndices

CC @alpencolt @jkotas

Author: viewizard
Assignees: -
Labels:

area-Diagnostics-coreclr
Milestone: -

jkotas added a commit to jkotas/runtime that referenced this issue Oct 12, 2022
@jkotas
Reintroduce typo in ICorDebug public API names
d4c3e1c 
Fixes dotnet#76960
@jkotas jkotas mentioned this issue Oct 12, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 12, 2022
@jkotas
Copy link
Member

jkotas commented Oct 12, 2022

I have missed the fact that the typo is being fixed in public documented API. I am going to re-introduce the typo.

@jkotas jkotas changed the title [Question] CoreCLR 7.0 have changed public Debug API. Why? CoreCLR 7.0 have changed public Debug API. Why? Oct 12, 2022
github-actions bot pushed a commit that referenced this issue Oct 12, 2022
@jkotas
Reintroduce typo in ICorDebug public API names
c460d15 
Fixes #76960
@tommcdon tommcdon added this to the 7.0.x milestone Oct 12, 2022
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Oct 12, 2022
@jkotas
Copy link
Member

jkotas commented Oct 12, 2022

Right, the typo is in this API name for 20+ years, so there is a quite a bit code written that depends on it.

jkotas added a commit that referenced this issue Oct 13, 2022
@jkotas
Reintroduce typo in ICorDebug public API names (#76966)
e216458 
Fixes #76960
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 13, 2022
carlossanlop pushed a commit that referenced this issue Oct 13, 2022
@github-actions @jkotas
[release/7.0] Reintroduce typo in ICorDebug public API names (#76967)
c7b59fc 
* Reintroduce typo in ICorDebug public API names

Fixes #76960

* Reintroduce ICorDebug typo in Mono partition as well

Fixes build break

Co-authored-by: Jan Kotas <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
7.0.x
Development

Successfully merging a pull request may close this issue.

Reintroduce typo in ICorDebug public API names jkotas/runtime
3 participants
@jkotas @tommcdon @viewizard