superpmi unit test dependencies build issue #76421
Comments
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThe superpmi unit test, src/tests/JIT/superpmi, has a project reference to two other projects (currently): Performance\CodeQuality\Bytemark\Bytemark.csproj These get built and copied into the superpmi unit test directory. The superpmi unit test then invokes them while doing a superpmi collection. As part of the new test execution system, 10w5d_cs_do was converted to not build as standalone, and so it no longer has a .cmd/.sh wrapper script. As a result, the superpmi unit test driver can't execute it. We need a way to build 10w5d_cs_do (and/or other tests) for use with the superpmi unit test, such that they are built with This change didn't cause a failure in the superpmi unit test itself due to insufficient error checking, fixed by #76411.
|
Add CscBench to get better C# coverage. Disable 10w5d_cs_do.csproj due to dotnet#76421
* Fix SuperPMI unit test error checking We were ignoring test failures, and even ignoring if the test we wanted to run under collection actually existed. This means that at some point during recent test reconfigurations, we stopped building 10w5d_cs_do.cmd/sh but we didn't notice. Because Bytemark kept being built as before, we got at least some .mc files. Add more checking that the programs we want to run exist, and that the tests we invoke pass. * Adjust superpmi unit test collection tests Add CscBench to get better C# coverage. Disable 10w5d_cs_do.csproj due to #76421
|
@BrianBohe @markples fyi, this will be an issue when converting more of the test tree to the new merged model. |
|
For now, I'm pretty sure that you can set |
ghost
added
the
in-pr
This should fix test builds with `set BuildAsStandalone=true`. - [Remove](5f14f05) unconditional `<BuildAsStandalone>false</BuildAsStandalone>` from various HardwareIntrinsics tests. This is already the default via Directory.Build.props but interferes with `set BuildAsStandalone=true`. (nit - also remove an empty `PropertyGroup` from GitHub_43569.csproj) - [Remove `Main` methods](0a886f8). We might be able to pursue a strategy where the test author provides a `Main(args)` method for local custom execution. The test would either need a separate parameterless [Fact] method or a [Theory] plus data for `Main` for merged group to execute it. However, a RequiresProcessIsolation/BuildAsStandalone build would ignore that metadata, so I'd like to avoid that complexity. The Main methods here set a bool or parse an int, which can be added locally to any test as needed. - [Add comment](e79a10c) to Directory.Merged.props (addressing feedback on #83462) - [Add the Methodical test back into the superpmi test](7c61de8) using RequiresProcessIsolation Fixes #76421 Fixes #81984
ghost
removed
the
in-pr
ghost
locked as resolved and limited conversation to collaborators
The superpmi unit test, src/tests/JIT/superpmi, has a project reference to two other projects (currently):
Performance\CodeQuality\Bytemark\Bytemark.csproj
Methodical\fp\exgen\10w5d_cs_do.csproj
These get built and copied into the superpmi unit test directory. The superpmi unit test then invokes them while doing a superpmi collection.
As part of the new test execution system, 10w5d_cs_do was converted to not build as standalone, and so it no longer has a .cmd/.sh wrapper script. As a result, the superpmi unit test driver can't execute it.
We need a way to build 10w5d_cs_do (and/or other tests) for use with the superpmi unit test, such that they are built with
BuildAsStandalone=true, or some other mechanism.This change didn't cause a failure in the superpmi unit test itself due to insufficient error checking, fixed by #76411.
The text was updated successfully, but these errors were encountered: