-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Windows build requirements - external tools vs. VS components #55629
Comments
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThe Requirements to build dotnet/runtime on Windows document lists a few external tools (namely CMake, Ninja and Python) that needs to be downloaded, installed and their executable added to the default PATH environment variable - but all these tools are already parts of the Visual Studio Community 2019 (with sufficient/higher versions) and can be easily installed via Visual Studio Installer (which can be automated further in provided .vsconfig), thus making the build environment setup basically just one-step VS install.
|
Closing (no feedback in almost a week). |
I like this idea. Are you interested in submitting a PR to update and simplify the requirement doc with this one-step VS install? |
I am sorry that nobody on the team found time to comment on this sooner. |
I think this is a good idea. At some point this wasn't included as the workloads were heavy (python) or didn't come with a high enough version (cmake). Now there's either the right versions, or enough checks in place to prevent that from breaking us. This would be a pretty good thing. Only thing to check is if our validation happens once the development environment has been initialized to ensure tools are in the path (would be a small change otherwise probably). |
Yes (however, English is not my native language, so it will definitely require some proofreading). |
No problem, I understand there is so much work going on, priorities etc. and only limited resources... |
I am thinking about adding something like
I have not checked the environment validation mechanism itself, but after installing the mentioned VS components (I have not installed the tools externally), the build and running test suite seems to be working, but it needs to be verified more thoroughly. |
Added description of build tools (CMake, Ninja and Python) installation as Visual Studio Individual Components. Added emphasis (bold) of Visual Studio installer sections and components (replaces previously used different styles of quotes).
* Added Visual Studio build tools (#55629) Added description of build tools (CMake, Ninja and Python) installation as Visual Studio Individual Components. Added emphasis (bold) of Visual Studio installer sections and components (replaces previously used different styles of quotes). * Removed Python 32-bit VS component Python 64-bit component is enough for building x86 and x64 target architectures. Co-authored-by: Juan Hoyos <[email protected]>
Fixed by #56234 |
The Requirements to build dotnet/runtime on Windows document lists a few external tools (namely CMake, Ninja and Python) that needs to be downloaded, installed and their executable added to the default PATH environment variable - but all these tools are already parts of the Visual Studio Community 2019 (with sufficient/higher versions) and can be easily installed via Visual Studio Installer (which can be automated further in provided .vsconfig), thus making the build environment setup basically just one-step VS install.
The text was updated successfully, but these errors were encountered: