-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline dependency issue: Artifact CoreCLRProduct bits missing. #53842
Comments
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsWe have builds failing to acquire the CoreCLR runtime bits. I am not sure why these are needed for the mono bits there. @directhex or @akoeplinger any idea there? For example https://dev.azure.com/dnceng/public/_build/results?buildId=1170249&view=logs&j=a3584aa7-f6a0-5e90-05ca-4edce1db7c76&t=6251704e-67a1-5275-71bd-ce7ee4c63087 This is likely caused by #53696 as product dependencies have been removed from the shared test build and this had an implicit dependency edge. We can get this working by adding the dependency explicitly if needed, or removing the download if not necessary. cc: @dotnet/runtime-infrastructure
|
Is CoreCLR's product build needed to build the coreroot on mono's builds? |
I believe so, see also #53421. |
So yes, based on the last comment this is bad. |
If someone knows how to add the dependency in the .yml please feel free to do it :) |
https://github.com/dotnet/runtime/blob/d617e830ec621db80f6df9ed8ba75176f5ba6035/eng/pipelines/runtime.yml#L596-603 is how you do dependence
…Sent from my iPhone
On Jun 10, 2021, at 8:43 AM, Alexander Köplinger ***@***.***> wrote:
If someone knows how to add the dependency in the .yml please feel free to do it :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This is a known issue that came out during the surge and that @naricc was working on. #43952 It seems like he has not gotten cycles to fix it. the short term fix should be make sure we are getting the right dependency always for mono against coreclr here:
|
…to solve pipeline issue dotnet#53842
… corerun procs (#54094) * Add dependency on coreclr in monojit/monointerpreter jobs explicitly to solve pipeline issue #53842 * Use Helix Pre/Post hooks to kill linkering corerun instances to work around ARM64 agent issues Co-authored-by: Kunal Pathak <[email protected]>
We have builds failing to acquire the CoreCLR runtime bits. I am not sure why these are needed for the mono bits there. @directhex or @akoeplinger any idea there? For example https://dev.azure.com/dnceng/public/_build/results?buildId=1170249&view=logs&j=a3584aa7-f6a0-5e90-05ca-4edce1db7c76&t=6251704e-67a1-5275-71bd-ce7ee4c63087
This is likely caused by #53696 as product dependencies have been removed from the shared test build and this had an implicit dependency edge. We can get this working by adding the dependency explicitly if needed, or removing the download if not necessary.
cc: @dotnet/runtime-infrastructure
Runfo Tracking Issue: Pipeline dependency issue: Artifact CoreCLRProduct bits missing.
Build Result Summary
The text was updated successfully, but these errors were encountered: