Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused interop code in System.Management #52458

Closed
mthalman opened this issue May 7, 2021 · 5 comments · Fixed by #52474
Closed

Unused interop code in System.Management #52458

mthalman opened this issue May 7, 2021 · 5 comments · Fixed by #52474
Assignees
@danmoseley
Labels
area-System.Management untriaged New issue has not been triaged by the area owner

Comments

@mthalman
Copy link
Member

mthalman commented May 7, 2021

The following types in https://github.com/dotnet/runtime/blob/98ac23212e6017c615e7e855e676fc43c8e44cb8/src/libraries/System.Management/src/System/Management/InteropClasses/WMIInterop.cs are unused and should be removed. One of the issues with having this code is that it leads to incorrect assumptions of what native dependencies the codebase has (part of dotnet/core#5651).

  • IWbemLocator
  • WbemLocator
  • IWbemServices_Old
  • IWbemShutdown
  • IUnsecuredApartment
  • UnsecuredApartment
  • IWbemPropertyProvider
  • IWbemEventProvider
  • IWbemEventProviderQuerySink
  • IWbemEventProviderSecurity
  • IWbemProviderIdentity
  • IWbemEventConsumerProvider
  • IWbemProviderInit
  • IWbemProviderInitSink
  • WbemDecoupledRegistrar
  • IWbemDecoupledRegistrar
  • MofCompiler
  • WbemBackupRestore
  • WbemDecoupledBasicEventProvider
  • WbemQuery
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 7, 2021
@danmoseley danmoseley self-assigned this May 7, 2021
hrrrrustic added a commit to hrrrrustic/runtime that referenced this issue May 7, 2021
@hrrrrustic
remove unused code fix dotnet#52458
8e236c3
@hrrrrustic
Copy link
Contributor

@danmoseley Uh, you've already picked this one :)

@hrrrrustic
Copy link
Contributor

Will you close it or I can submit PR? 😄

@danmoseley
Copy link
Member

I'll have a PR up in a moment. Just an easy one to do between meetings 😄

@danmoseley
Copy link
Member

Oh, I see you already did it. Well, I'll just push up the PR since I said I'd do it now. thanks though!

@danmoseley danmoseley mentioned this issue May 7, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 7, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danmoseley danmoseley

Labels
area-System.Management untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dead interop code in System.Management danmoseley/runtime
3 participants
@danmoseley @mthalman @hrrrrustic