-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid generating degenerate flow during redundant branch optimization #48609
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
in-pr
There is an active PR which will close this issue when it is merged
Milestone
Comments
dotnet-issue-labeler
bot
added
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
untriaged
New issue has not been triaged by the area owner
labels
Feb 22, 2021
@dotnet/jit-contrib , @AndyAyersMS |
JulieLeeMSFT
removed
the
untriaged
New issue has not been triaged by the area owner
label
Feb 25, 2021
Not urgent for .NET 6. |
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this issue
Mar 11, 2024
Detect if the update has created degenerate BBJ_COND flow, and simplify. Also symmetrize the true/false cases. Fixes dotnet#48609. Also fixes some issues seen in enhanced likelhood checking.
dotnet-policy-service
bot
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
Mar 11, 2024
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this issue
Mar 11, 2024
Detect if the update has created degenerate BBJ_COND flow, and simplify. Also symmetrize the true/false cases. Fixes dotnet#48609. Also fixes some issues seen in enhanced likelhood checking.
AndyAyersMS
added a commit
that referenced
this issue
Mar 11, 2024
Detect if the update has created degenerate BBJ_COND flow, and simplify. Fixes #48609. Also fixes some issues seen in enhanced likelihood checking.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
in-pr
There is an active PR which will close this issue when it is merged
Today, we might end up generating degenerate flow during redundant branch optimization. We need to make sure that we don't do that and add an assertion check to make sure that we never have
flDupCount > 1
unless it is a switch statement.We saw #47101 issue because of this and it was fixed in #48607 by making sure assertion prop handles it. But eventually "redundant branch optimization" should not create such flow.
category:cq
theme:flowgraph
The text was updated successfully, but these errors were encountered: