wasm AOT library test failure - System.Runtime.Serialization.InvalidDataContractException NoSetMethodForProperty

[mdh1418]

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Runtime.Serialization.Json.ReflectionOnly.Tests.csproj fails with

System.Runtime.Serialization.InvalidDataContractException : NoSetMethodForProperty

System.NotImplementedException : Arg_NotImplementedException

SRSJR_fail.txt

Repro:
Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

	<!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved -->
	<assembly fullname="Microsoft.DotNet.RemoteExecutor">
	<type fullname="Microsoft.DotNet.RemoteExecutor.Program">
	<method signature="System.Int32 Main(System.String[])" />
	</type>
	</assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Runtime.Serialization.Json/tests/ReflectionOnly/System.Runtime.Serialization.Json.ReflectionOnly.Tests.csproj

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Runtime.Serialization.Json.ReflectionOnly.Tests.csproj fails with

System.Runtime.Serialization.InvalidDataContractException : NoSetMethodForProperty

System.NotImplementedException : Arg_NotImplementedException

SRSJR_fail.txt

Repro:
Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

	<!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved -->
	<assembly fullname="Microsoft.DotNet.RemoteExecutor">
	<type fullname="Microsoft.DotNet.RemoteExecutor.Program">
	<method signature="System.Int32 Main(System.String[])" />
	</type>
	</assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Runtime.Serialization.Json/tests/ReflectionOnly/System.Runtime.Serialization.Json.ReflectionOnly.Tests.csproj

Author:	mdh1418
Assignees:	-
Labels:	arch-wasm, area-Infrastructure-libraries
Milestone:	-

[layomia]

cc @eerhardt since the description mentions linking.

[radical]

I get lot of test failures with just EnableAggressiveTrimming, and no AOT compilation. eg:

  fail: [FAIL] DataContractJsonSerializerTests.DCJS_VerifyDictionaryFormat
  info: System.Runtime.Serialization.InvalidDataContractException : NoSetMethodForProperty, System.Runtime.Serialization.KeyValue`2[System.String,System.String], Key
  info:    at System.Runtime.Serialization.DataContract.DataContractCriticalHelper.ThrowInvalidDataContractException(String message, Type type)
  info:    at System.Runtime.Serialization.DataContract.DataContractCriticalHelper.ThrowInvalidDataContractException(String message)
  info:    at System.Runtime.Serialization.ClassDataContract.ClassDataContractCriticalHelper.ImportDataMembers()
  info:    at System.Runtime.Serialization.ClassDataContract.ClassDataContractCriticalHelper..ctor(Type type, XmlDictionaryString ns, String[] memberNames)
  info:    at System.Runtime.Serialization.ClassDataContract..ctor(Type type, XmlDictionaryString ns, String[] memberNames)
  info:    at System.Runtime.Serialization.ClassDataContract.CreateClassDataContractForKeyValue(Type type, XmlDictionaryString ns, String[] memberNames)
  info:    at System.Runtime.Serialization.CollectionDataContract.CollectionDataContractCriticalHelper.get_ItemContract()
  info:    at System.Runtime.Serialization.CollectionDataContract.InitCollectionDataContract(DataContract sharedTypeContract)
  info:    at System.Runtime.Serialization.CollectionDataContract..ctor(Type type, CollectionKind kind, Type itemType, MethodInfo getEnumeratorMethod, MethodInfo addMethod, ConstructorInfo constructor, Boolean isConstructorCheckRequired)
  info:    at System.Runtime.Serialization.CollectionDataContract.IsCollectionOrTryCreate(Type type, Boolean tryCreate, DataContract& dataContract, Type& itemType, Boolean constructorRequired)
  info:    at System.Runtime.Serialization.CollectionDataContract.TryCreate(Type type, DataContract& dataContract)
  info:    at System.Runtime.Serialization.DataContract.DataContractCriticalHelper.CreateDataContract(Type type)
  info:    at System.Runtime.Serialization.DataContract.DataContractCriticalHelper.CreateDataContract(Int32 id, RuntimeTypeHandle typeHandle, Type type)
  info:    at System.Runtime.Serialization.DataContract.DataContractCriticalHelper.GetDataContractSkipValidation(Int32 id, RuntimeTypeHandle typeHandle, Type type)
  info:    at System.Runtime.Serialization.DataContract.GetDataContractSkipValidation(Int32 id, RuntimeTypeHandle typeHandle, Type type)
  info:    at System.Runtime.Serialization.DataContract.GetDataContract(RuntimeTypeHandle typeHandle, Type type, SerializationMode mode)
  info:    at System.Runtime.Serialization.DataContract.GetDataContract(RuntimeTypeHandle typeHandle, Type type)
  info:    at System.Runtime.Serialization.DataContract.GetDataContract(Type type)
  info:    at System.Runtime.Serialization.Json.DataContractJsonSerializerImpl.get_RootContract()
  info:    at System.Runtime.Serialization.Json.DataContractJsonSerializerImpl.InternalWriteObjectContent(XmlWriterDelegator writer, Object graph)
  info:    at System.Runtime.Serialization.Json.DataContractJsonSerializerImpl.InternalWriteObject(XmlWriterDelegator writer, Object graph)
  info:    at System.Runtime.Serialization.XmlObjectSerializer.InternalWriteObject(XmlWriterDelegator writer, Object graph, DataContractResolver dataContractResolver)
  info:    at System.Runtime.Serialization.XmlObjectSerializer.WriteObjectHandleExceptions(XmlWriterDelegator writer, Object graph, DataContractResolver dataContractResolver)
  info:    at System.Runtime.Serialization.XmlObjectSerializer.WriteObjectHandleExceptions(XmlWriterDelegator writer, Object graph)
  info:    at System.Runtime.Serialization.Json.DataContractJsonSerializerImpl.WriteObject(XmlDictionaryWriter writer, Object graph)
  info:    at System.Runtime.Serialization.Json.DataContractJsonSerializerImpl.WriteObject(Stream stream, Object graph)
  info:    at System.Runtime.Serialization.Json.DataContractJsonSerializer.WriteObject(Stream stream, Object graph)
  info:    at DataContractJsonSerializerTests.SerializeAndDeserialize[Dictionary`2](Dictionary`2 value, String baseline, DataContractJsonSerializerSettings settings, Func`1 serializerFactory, Boolean skipStringCompare)
  info:    at DataContractJsonSerializerTests.DCJS_VerifyDictionaryFormat()
  info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

I think those need to be cleared before trying this with AOT.

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Runtime.Serialization.Json.ReflectionOnly.Tests.csproj fails with

System.Runtime.Serialization.InvalidDataContractException : NoSetMethodForProperty

System.NotImplementedException : Arg_NotImplementedException

SRSJR_fail.txt

Repro:
Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

	<!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved -->
	<assembly fullname="Microsoft.DotNet.RemoteExecutor">
	<type fullname="Microsoft.DotNet.RemoteExecutor.Program">
	<method signature="System.Int32 Main(System.String[])" />
	</type>
	</assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Runtime.Serialization.Json/tests/ReflectionOnly/System.Runtime.Serialization.Json.ReflectionOnly.Tests.csproj

Author:	mdh1418
Assignees:	-
Labels:	area-Serialization, linkable-framework, untriaged
Milestone:	-