Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./build.sh --portablebulid false fails #43219

Closed
omajid opened this issue Oct 9, 2020 · 5 comments · Fixed by #50097
Closed

./build.sh --portablebulid false fails #43219

omajid opened this issue Oct 9, 2020 · 5 comments · Fixed by #50097
Labels
area-Infrastructure-libraries
Milestone
6.0.0

Comments

@omajid
Copy link
Member

omajid commented Oct 9, 2020

I would like to add a build configuration in CI to help catch issues like #42415. That is, essentially do a ./build.sh --portablebuild false in a CI leg (on x64).

But that doesn't seem to work on Fedora or RHEL systems that I tried it on.

They all fail with a messages like

/home/dotnet/runtime/src/libraries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj : error NU1101: Unable to find package runtime.rhel.8-x64.microsoft.netcore.ilasm. No packages exist with this id in source(s): dotnet-eng

It's complaining that the ilasm assets for non-portable RIDs can not be found.

Does a portable build work outside of source-build? Is there a way I can make the build use portable nuget packages for tools like ilasm?
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Oct 9, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@omajid
Copy link
Member Author

omajid commented Oct 9, 2020

cc @tmds

@omajid
Copy link
Member Author

omajid commented Dec 10, 2020

Any thoughts, @crummel @dagood @dleeapho @dseefeld @jeffschwMSFT @ViktorHofer on how to get portable builds to work?

@ViktorHofer
Copy link
Member

cc @ericstj

@ericstj
Copy link
Member

ericstj commented Dec 11, 2020

Sounds like the RID used for locating ILAsm is out of sync with that used for the CLI. We know there is dotnet runtime that works otherwise you wouldn’t have gotten this far.

@safern safern added this to the 5.0.x milestone Feb 18, 2021
@safern safern removed the untriaged New issue has not been triaged by the area owner label Feb 18, 2021
@safern safern modified the milestones: 5.0.x, 6.0.0 Feb 18, 2021
@safern safern modified the milestones: 6.0.0, 5.0.x Feb 18, 2021
@safern safern modified the milestones: 5.0.x, 6.0.0 Feb 18, 2021
@omajid omajid mentioned this issue Mar 23, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 23, 2021
omajid added a commit to omajid/dotnet-runtime that referenced this issue Apr 15, 2021
@omajid
Fix ./build.sh --portableBuild false
4fa7e11 
Non-portable builds are used by source-build and also use for
testing/debugging things, like trying out OpenSSL 3.0:
dotnet#46526 (comment)

Fixes: dotnet#43219
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix ./build.sh --portableBuild false omajid/dotnet-runtime
5 participants
@omajid @ViktorHofer @ericstj @safern @Dotnet-GitSync-Bot