Prefer Nullable<T>.GetValueOrDefault() over manual checking

[terrajobst]

After checking a Nullable<T>.HasValue, it's common to see calls to Nullable<T>.Value; instead of calling Value, it's less work to call GetValueOrDefault(), as Value repeats the HasValue check. It's possible a future JIT could optimize away the duplicate check, but if nothing else using GetValueOrDefault() makes the job of the JIT easier.

Category: Performance

[jeffhandley]

Estimates:

• Analyzer: Medium
• Fixer: Medium

[GSPP]

This is a high-noise analyzer. GetValueOrDefault is preferable from a performance standpoint, but this does not matter for 99% of the code.

From a style perspective, Value is preferable because semantically is more correct than GetValueOrDefault. You never want a default. If anything, you want the explicit assertion in Value.

If many high-noise analyzers like this one are default-on then people will learn that the analyzer suite is not meaningful to their work.

[stephentoub]

If many high-noise analyzers like this one are default-on then people will learn that the analyzer suite is not meaningful to their work.

It wouldn't be on by default.

[xtqqczze]

There is an existing code quality issue for Nullable<T>.Value following Nullable<T>.HasValue (#13699).