Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use "dev" prerelease tag for local builds, rather than "dev.12345.1"? #246

Closed
dagood opened this issue Nov 25, 2019 · 2 comments
Closed
Labels
area-Meta discussion untriaged New issue has not been triaged by the area owner

Comments

@dagood
Copy link
Member

dagood commented Nov 25, 2019

Right now, a local dev build gives us a version like this: 5.0.0-dev.19569.1. In Core-Setup, this used to be 5.0.0-dev pre-consolidation.

As far as preference goes, I like dev because I can use the same incremental build results over multiple days without any hassle.

With dev.19569.1:

  1. I need to rebuild every day, or figure out what MSBuild property to set to let me use the same build across days.
  2. I have to figure out what number (date?) to put in to match some earlier build's number (some derivative of date?), if I forgot to override it when running an earlier build.
  3. The artifact directory expands over time unless I take action to manually clean up old versions periodically. This also makes it harder to find my actual build artifacts.

Is there an argument for using numbers in the prerelease tag for local builds? Is there a technical reason?

(If there's some hard technical reason, I do think that being the same across all subsets is much more important than making a single subset easier to deal with.)

@dotnet/runtime-infrastructure I'm curious what your thoughts are on this.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 25, 2019
@dagood
Copy link
Member Author

dagood commented Dec 5, 2019

In a standup meeting we had today, this came up, and it turns out the daily rebuild requirement is only for the Installer build's usage of the Libraries subset.

@dagood
Copy link
Member Author

dagood commented Jan 28, 2020

Closing: as of #1835, non-CI builds no longer use the date for filenames! 🎉

@dagood dagood closed this as completed Jan 28, 2020
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Nov 4, 2020
I think this is not needed after dotnet#211.

There still is a JIT bug or too strong assert, but that's tracked in the runtime repo.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta discussion untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

2 participants