Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2: Two remote server tests occasionally timing out in CI #1580

Closed
geoffkizer opened this issue Jul 16, 2019 · 10 comments · Fixed by #94115
Closed

HTTP2: Two remote server tests occasionally timing out in CI #1580

geoffkizer opened this issue Jul 16, 2019 · 10 comments · Fixed by #94115
Assignees
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Milestone

Comments

@geoffkizer
Copy link
Contributor

These are tests I'm modifying to run with HTTP2 in dotnet/corefx#39343 but disabling for now.

Sometimes in CI, these tests timeout. Likely they are just running really slowly in CI and increasing the timeout would make them more reliable. We should investigate and confirm and change the timeout as appropriate.

PostAsync_RedirectWith307_LargePayload
PostRewindableContentUsingAuth_NoPreAuthenticate_Success

@eiriktsarpalis
Copy link
Member

Would you be able to point to examples of failing builds? I'm going through the outerloop build history but haven't been able to find failing instances (presumably because they have been skipped since the beginning of time?). Example 1 or Example 2.

@eiriktsarpalis
Copy link
Member

@geoffkizer
Copy link
Contributor Author

Yeah, that's one of the runs I saw. There was at least one other run on that PR (before I disabled the tests) that failed both as well.

@eiriktsarpalis
Copy link
Member

FWIW that failure is targeting the platform handler.

@geoffkizer
Copy link
Contributor Author

FWIW that failure is targeting the platform handler.

Interesting. That would seem to point to the issue being either (a) CI slowness or (b) remote server slowness, as opposed to a product issue, since it seems to happen with different handlers.

@stephentoub
Copy link
Member

I don't think this blocks 3.0. Pushing out.

@eiriktsarpalis
Copy link
Member

What's the best way to address this issue going forward? The test failures are long gone from the build history so there's not much context. @geoffkizer should we maybe try re-enabling tests for HTTP2 and observe how they behave?

@karelz
Copy link
Member

karelz commented Oct 4, 2019

@eiriktsarpalis are you working on it? If not, please unassign yourself. Thanks!

@eiriktsarpalis
Copy link
Member

Was working on this before my trip. Can confirm that the test is timing out consistently with the platform handler on linux CI, but it does not reproduce on my linux machine.

@eiriktsarpalis eiriktsarpalis removed their assignment Oct 7, 2019
@danmoseley danmoseley transferred this issue from dotnet/corefx Jan 9, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 9, 2020
@danmoseley danmoseley added disabled-test The test is disabled in source code against the issue test-bug Problem in test source code (most likely) labels Jan 9, 2020
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Feb 13, 2020
@karelz karelz added this to the 5.0 milestone Feb 24, 2020
@karelz karelz added the test-run-core Test failures in .NET Core test runs label Feb 24, 2020
@karelz karelz modified the milestones: 5.0, Future Jun 5, 2020
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Dec 9, 2021
@ManickaP ManickaP modified the milestones: Future, 9.0.0 Sep 19, 2023
@ManickaP
Copy link
Member

Triage: either fix the tests or get rid of them or just disable them in CI, but run them locally if it's impossible to run in CI.

@wfurt wfurt self-assigned this Oct 25, 2023
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 27, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 30, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Projects
None yet
8 participants