System.Resources.Extensions 9.0.1 NuGet addresses wrong version in targets file

[Dany-HBK]

Description

The NuGet package system.resources.extensions.9.0.1.nupkg references version 9.0.0.0 in its targets file, producing a runtime error that this assembly cannot be found.

Used in a project targeting .NET Framework 4.8.

Reproduction Steps

1. Create a .NET Framework 4.8 WinForms project ( TestProject ) -> See PropertyGroup below.
2. Add a reference to the NuGet package ("Latest stable 9.0.1").
3. Add an image resource to the project ( MyImage ).
4. Add a Button control on the Form ( button1 ).
5. Assign the image resource to the Button control. ( this.button1.Image = global::TestProject.Properties.Resources.MyImage; in Designer file ).
6. Run the application

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFrameworks>net48</TargetFrameworks>
    <Platforms>AnyCPU</Platforms>
    <RuntimeIdentifiers>win-AnyCPU</RuntimeIdentifiers>
    <UseWindowsForms>true</UseWindowsForms>
    <AppendTargetFrameworkToOutputPath>False</AppendTargetFrameworkToOutputPath>
    <GenerateResourceUsePreserializedResources>true</GenerateResourceUsePreserializedResources>
  </PropertyGroup>

Expected behavior

The Form opens and displays the Button with the image.

Actual behavior

Exception at the Designer code line above (German OS):

An unhandled exception of type 'System.IO.FileLoadException' occurred in mscorlib.dll
Die Datei oder Assembly "System.Resources.Extensions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" oder eine Abhängigkeit davon wurde nicht gefunden. Die gefundene Manifestdefinition der Assembly stimmt nicht mit dem Assemblyverweis überein. (Ausnahme von HRESULT: 0x80131040)

Regression?

With version 9.0.0 of this NuGet package it works of course.

Known Workarounds

Use version 9.0.0 of the package.

Configuration

• .NET Framework 4.8
• Windows 10 22H2 (German)
• x64
• Configuration independent (but .NET Runtime dependent)

Other information

Just a forgotten change since the Assembly version has been bumped up (which is probably the fault) but not the targets file.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

[semihkiroglu]

I have the same problem in my Outlook VSTO Add-in project (.NET Framework 4.8 - x64). It redirects to 9.0.0.0 when AutoGenerateBindingRedirects is true. If I set AutoGenerateBindingRedirects false and update it to 9.0.0.1 it works, but I don't want to use AutoGenerateBindingRedirects false, I have a lot of dependencies and don't want to manage them manually.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-resources
See info in area-owners.md if you want to be subscribed.

[jeffhandley]

@ericstj Let me know if you disagree on this area routing. Either way, I'll need your help understanding if there's something incorrect with the project/package here.

[Dany-HBK]

Hi, I thought my description was clear, just let me go more into detail:

1. Just install the NuGet package mentioned.
2. Browse to %USERPROFILE%\.nuget\packages\system.resources.extensions\9.0.1\buildTransitive\net462\.
3. Now open the file System.Resources.Extensions.targets with a text editor of your choice.
4. In tag SuggestedBindingRedirects you can find MaxVersion="9.0.0.0".
   This version is just incorrect, it has to be MaxVersion="9.0.1.0" that the package can be used with .NET Framework 4.8 (4.6.2 onward). Right now it will produce the runtime exception above as it tries to load version 9.0.0.0 which is of course not available.

[St-LF]

Hi, I thought my description was clear, just let me go more into detail:

1. Just install the NuGet package mentioned.
2. Browse to %USERPROFILE%\.nuget\packages\system.resources.extensions\9.0.1\buildTransitive\net462\.
3. Now open the file System.Resources.Extensions.targets with a text editor of your choice.
4. In tag SuggestedBindingRedirects you can find MaxVersion="9.0.0.0".
   This version is just incorrect, it has to be MaxVersion="9.0.1.0" that the package can be used with .NET Framework 4.8 (4.6.2 onward). Right now it will produce the runtime exception above as it tries to load version 9.0.0.0 which is of course not available.

9.0.1.0, do you mean 9.0.0.1

[Dany-HBK]

9.0.1.0, do you mean 9.0.0.1

When you look at the folder structure closely, you can see 9.0.1 (NuGet packages usually have only 3 parts), so no, I really mean 9.0.1.0 ;)
Argh, I have to correct myself: Somehow ILSpy says the assembly has version 9.0.0.1. Why does the package have 9.0.1?

[ericstj]

It's expected to require bindingRedirects during servicing, the assembly version increment is also expected (9.0.0.1), as is the package version.

This package is special in that it's references to a specific version aren't seen by ResolveAssemblyReferences because they exist in an assemblies resources and not necessarily as a reference from the assembly itself - so the part of MSBuild that is meant to generate redirects misses it. As a result the package includes targets to specify the redirect itself.

I can agree with the reports here that the targets have the incorrect version:
system.resources.extensions\9.0.1\buildTransitive\net462\System.Resources.Extensions.targets mentions

<SuggestedBindingRedirects Include="System.Resources.Extensions, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" MaxVersion="9.0.0.0" />

Whereas system.resources.extensions\9.0.1\lib\net462\System.Resources.Extensions.dll has version:

[assembly: AssemblyVersion("9.0.0.1")]

The problem is that the generated targets file is produced in the outer build of the project - which won't get the .NETFramework specific versioning.

We should fix this and backport to 9.0. Thank you for the report!

For now, you can workaround this by adding a redirect for 9.0.0.1 and excluding the wrong one added by the package:

  <ItemGroup>
    <PackageReference Include="system.resources.extensions" Version="9.0.1" ExcludeAssets="BuildTransitive"/>
    <SuggestedBindingRedirects Include="System.Resources.Extensions, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" MaxVersion="9.0.0.1" />
  </ItemGroup>