Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versioning scheme for Microsoft.DotNet.Cecil #103589

Open
sbomer opened this issue Jun 17, 2024 · 1 comment
Open

Update versioning scheme for Microsoft.DotNet.Cecil #103589

sbomer opened this issue Jun 17, 2024 · 1 comment
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Milestone
10.0.0

Comments

@sbomer
Copy link
Member

sbomer commented Jun 17, 2024

Currently we build Microsoft.DotNet.Cecil (from dotnet/cecil) using a versioning scheme that matches upstream (jbevain/cecil). This is left over from when we used to depend on the upstream Mono.Cecil in dotnet/linker (see https://github.com/dotnet/linker/pull/1515/files for more context).

Now that we no longer depend on the upstream build, we could adopt the common versioning scheme used by other components.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 17, 2024
@sbomer sbomer mentioned this issue Jun 17, 2024
Merged
@sbomer sbomer added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jun 17, 2024
@sbomer sbomer added this to the 9.0.0 milestone Jun 17, 2024
@sbomer sbomer removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 17, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@sbomer sbomer mentioned this issue Jun 18, 2024
Merged
sbomer added a commit that referenced this issue Jun 18, 2024
@sbomer
Remove cecil version check (#103665)
7172a7d 
Fixes #103563. The fix in
[cecil](dotnet/cecil#192) is taking too long
to [flow](#103574), and the test
is no longer needed per
#103589.
@sbomer sbomer modified the milestones: 9.0.0, 10.0.0 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
AppModel
Status: No status
Milestone
10.0.0
Development

No branches or pull requests
1 participant
@sbomer