Comment dispose

dotnet · Jul 12, 2020 · c87e75e · c87e75e
1 parent 0f770d5
commit c87e75e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...ibraries/System.ServiceProcess.ServiceController/src/System/ServiceProcess/ServiceBase.cs b/...ibraries/System.ServiceProcess.ServiceController/src/System/ServiceProcess/ServiceBase.cs
@@ -305,6 +305,8 @@ internal static bool ValidServiceName(string serviceName)
         /// <devdoc>
         ///    <para>Disposes of the resources (other than memory ) used by
         ///       the <see cref='System.ServiceProcess.ServiceBase'/>.</para>
+        ///    This is called from <see cref="Run(ServiceBase[])"/> when all
+        ///    services in the process have entered the SERVICE_STOPPED state.
         /// </devdoc>
         protected override void Dispose(bool disposing)
         {

diff --git a/...erviceController/tests/System.ServiceProcess.ServiceController.TestService/TestService.cs b/...erviceController/tests/System.ServiceProcess.ServiceController.TestService/TestService.cs
@@ -116,6 +116,10 @@ public async Task WriteStreamAsync(PipeMessageByteCode code, int command = 0)
             }
         }
 
+        /// <summary>
+        /// This is called from <see cref="ServiceBase.Run(ServiceBase[])"/> when all services in the process
+        /// have entered the SERVICE_STOPPED state. It disposes the named pipe stream.
+        /// </summary>
         protected override void Dispose(bool disposing)
         {
             if (!_disposed)