Skip to content

Commit

Permalink
[mono][xunit tests] Move skipped tests out of rsp file (#2087)
Browse files Browse the repository at this point in the history
Addresses #1980

* [xunit tests][mono] Remove disabled Microsoft.VisualBasic.Core.Tests tests from rsp file.

* [xunit tests][mono] Remove System.Collections.Specialized.Tests.Ctor_NegativeCapacity_ThrowsArgumentOutOfRangeException from rsp file

* Remove System.Collections.Concurrent.Tests.ConcurrentQueueTests.ReferenceTypes_NulledAfterDequeue from rsp file because it passes on release mono

* Remove BasicEventSourceTests.TestsManifestNegative.Test_GenerateManifest_InvalidEventSources from rsp file because it passes locally

* Remove ManagedTests.DynamicCSharp.Conformance.dynamic.overloadResolution.Methods.Oneclass2methods.twoprms004.twoprms004.Test.DynamicCSharpRunTest from rsp file

* Remove System.IO.Tests.*.CopyFileWithData_MemberData from rsp file

* Move a set of skipped System.Linq.Expressions.Tests out of rsp file.

* Annotate System.Collections.Concurrent.Tests.ConcurrentQueueTests.ReferenceTypes_NulledAfterDequeue with ActiveIssue attribute

* Move another set of skipped System.Linq.Expressions.Tests out of rsp file.

* Move skipped System.Linq.Parallel.Tests.PlinqModesTests.WithExecutionMode_Multiple test out of rsp file

* Move skipped System.Memory.Tests out of rsp file

* Move skipped System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler.* tests out of rdp file

* Remove System.Net.Sockets.Tests.SocketOptionNameTest.MulticastInterface_Set_AnyInterface_Succeeds because it passes locally.

* Move System.Reflection tests with an active issue out of rsp file

* Move skipped System.Runtime.InteropServices.Tests out of rsp file

* Replace closed CoreFX GH issue with the active Runtime one

* Move skipped System.Runtime.Serialization.Formatters.Tests out of rsp file

* Move skipped System.Runtime.Tests with an active issue out of rsp file

* Move skipped System.Threading.Tests with an active issue out of rsp file

* Remove skipped System.Data.Common.Tests because the related issue was addressed

* Move skipped System.Data.Common.Tests.DbConnectionTests.ProviderFactoryTest with an active issue out of rsp file

* Move skipped System.Diagnostics.StackTrace.Tests with an active issue out of rsp file

* Move skipped System.Numerics.Vectors.Tests with an active issue out of rsp file

* Move skipped System.Reflection.Context.Tests with an active issue out of rsp file

* Move skipped System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest with an active issue out of rsp

* Move skipped System.ComponentModel.Composition and Tests.Integration namespaces with an active issue out of rsp file

* Update a message in skipped System.Runtime.InteropServices.Tests

* Move skipped System.Reflection.Tests.MetadataTokenTests.SuccessImpliesNonNilWithCorrectTable with an active issue out of rsp file

* Move skipped/no repro System.Threading.Overlapped.Tests with an active issue out of rsp file

* Move skipped System.Runtime.Extensions with an active issue out of rsp file

* Re-enable skipped System.Runtime.Handles.Tests because the related issue was addressed

* Move skipped System.Reflection.TypeExtensions.Tests with an active issue out of rsp file

* Move skipped System.Reflection.Emit.Lightweight.Tests with an active issue out of rsp file

* Move skipped System.Reflection.MetadataLoadContext.Tests with an active issue out of rsp file

* Move skipped System.Xml.Xsl.XslTransformApi.Tests with an active issue out of rsp file

* Move skipped System.Security.Cryptography.Encoding.Tests with an active issue out of rsp file

* Move System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException out of rsp file

* Add an active issue attribute to System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException test; add a comment about libgdiplus dependency to PlatformDetection.IsDrawingSupported method.

* Move System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ClientCertificates_Test.AutomaticOrManual_DoesntFailRegardlessOfWhetherClientCertsAreAvailable out of rsp because it has an active corefx issue; see https://github.com/dotnet/corefx/issues/37336

* Remove System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_DangerousAcceptAllCertificatesValidator_Test.SetDelegate_ConnectionSucceeds from rsp because it's already disabled as part of system.net.* tests; see #2318

* Move skipped System.Reflection.Emit.ILGeneration.Tests with an active issue out of rsp file

* Move skipped System.Reflection.Emit.Tests with an active issue out of rsp file

* Remove skipped System.Reflection.Tests from rsp file because they pass locally

* Try to re-enabled skipped System.Reflection.Tests.AssemblyTests.LoadFromStream_Location_IsEmpty

* Remove broken namespace

* Add an active issue to System.Reflection.Tests.AssemblyTests.LoadFromStream_Location_IsEmpty

* Add an active issue to several System.Reflection tests

* Remove skipped System.Tests.ExitCodeTests.SigTermExitCode because it passes locally.

* Remove skipped System.Tests.Types.VoidTests.IsByRef_Get_ReturnsExpected from rsp file because it passes locally

* Remove skipped System.Tests.GCTests.LatencyRoundtrips from rsp file because it passes locally

* Remove skipped System.Tests.GCExtendedTests.GetGCMemoryInfo from rsp-file because the related functionality has been implemented (see mono/mono#15236)

* Remove skipped System.Tests.GetEnvironmentVariable.EnvironmentVariablesAreHashtable from rsp file because it passes locally

* Turn System.Threading.Tasks.Tests.ExecutionContextFlowTest.TaskCompletionSourceDoesntCaptureExecutionContext into a conditional theory because it requires precise GC

* Try to re-enable System.Threading.Tasks.Tests.TaskContinueWithTests.LongContinuationChain_ContinueWith_DoesNotStackOverflow

* Remove skipped System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinThreadsTo0Test from rsp file because it passes locally

* Remove System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest_ChangedInDotNetCore from rsp file because it's explicitly skipped on Mono using SkipOnTargetFramework attribute

* Add an active issue to System.Tests.ExitCodeTests.SigTermExitCode and System.Tests.GCTests.LatencyRoundtrips tests

* Remove skipped System.Data.Tests.SqlTypes.SqlCharsTest.ReadWriteXmlTest from rsp file because it passes locally

* Add an active issue to System.Tests.GCExtendedTests.GetGCMemoryInfo because it fails on helix

* Add an active issue

* Add an active issue

* Re-add an active issue to System.Tests.ExceptionTests.ThrowStatementDoesNotResetExceptionStackLineOtherMethod

* Move skipped System.ComponentModel.Composition.MetadataViewProviderTests.GetMetadataView_InterfaceWithIndexer_ShouldThrowNotSupportedException with an active issue out of rsp file (see mono/mono#15169)

* Remove skipped Tests.Integration.ExportFactoryTests.ExportFactoryStandardImports_ShouldWorkProperly from rsp file because it's already disabled within the entire Tests.Integration.ExportFactoryTests class (see mono/mono#16417)

* Remove several skipped System.ComponentModel.Composition.Tests from rsp file because they pass locally.

* Move skipped System.ComponentModel.Composition.ExportCollectionTests.ImportCollectionsFromContainerOnly with an active issue out of rsp file

* Move skipped System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_SkipFrames and System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_SkipFrames_FNeedFileInfo tests with an active issue out of rsp file.

* Move skipped System.Diagnostics.Tests.StackTraceTests.ToString_Invoke_ReturnsExpected with an active issue out of rsp file

* Remove skipped System.Reflection.Tests.MetadataLoadContextTests.RelocatableAssembly from rsp file because it passes locally.

* Move skipped System.Runtime.Loader.Tests.RefEmitLoadContextTests.LoadRefEmitAssembly with an active issue out of rsp file

* Moved skipped ThreadPoolBoundHandleTests.PreAllocatedOverlapped_NullAsCallback_ThrowsArgumentNullException with an active issue out of rsp file (see mono/mono#15313)

* Move skipped System.Runtime.Tests.ProfileOptimizationTest.ProfileOptimization_CheckFileExists with an active issue out of rsp file

* Move skipped System.Reflection.Emit.Tests.DynamicILInfoTests with an active issue out of rsp file

* Move skipped System.Reflection.Emit.Tests.DynamicILInfoTests.SetX_NullInput_ThrowsArgumentNullException and System.Reflection.Emit.Tests.DynamicMethodctor1.InvalidOwner_ThrowsArgumentException with an active issue out of rsp file

* Add an active issue to System.Threading.Tasks.Tests.TaskContinueWithTests.LongContinuationChain_ContinueWith_DoesNotStackOverflow because it's flaky

* Add an active issue to Tests.Integration.DiscoveryTests.DiscoverAddinsWithCombinedCustomExportAndMetadataAttribute

* Add an active issue to System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest_ChangedInDotNetCore

* Add an active issue to System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTestWithTransparentViews

* Replace TargetFrameworkMonikers.Mono with TestRuntimes.Mono

* Remove redundant space

* Remove all -notrait category

* Add an active issue to System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTest

* Add an active issue to System.ComponentModel.Composition.CompositionContainerTests.GetExportOfTTMetadataView1_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstraint

* Disable the whole System.ComponentModel.Composition.Tests namespace

* Move some System.Runtime.Loader.Tests, which rely on collectible AssemblyLoadContext, out of rsp file

* Remove three System.Runtime.Loader.Tests.AssemblyLoadContextTest tests with no local failures from rsp file

* Remove System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadNonExistentInDefaultContext and System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadInDefaultContext from rsp file because the related issues should be addressed

* Add an active issue to System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadNonExistentInDefaultContext and System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadInDefaultContext because they fail on CI

* Move several System.Runtime.Loader.Tests.AssemblyLoadContextTest with an active issues out of rsp file

* Remove System.Utf8String.Experimental.Tests from rsp file to verify how they behave on CI

* Clean up rsp file to check all remaining failures

* Skip the entire System.ComponentModel.Composition.Registration.Tests namespace on Mono

* Disable a set of classes in System.Utf8String.Experimental.Tests workspace.

* Add stubs for Utf8String and Utf8Span.cs classes to fix the test build on Mono

* Remove nint/nunit aliases unused in PNSE version of Utf8Span

* Remove CoreFX.issues.rsp file because it has been cleaned up
  • Loading branch information
MaximLipnin committed Feb 18, 2020
1 parent 6c3b8ad commit b74422f
Show file tree
Hide file tree
Showing 203 changed files with 808 additions and 937 deletions.
1 change: 0 additions & 1 deletion eng/testing/tests.targets
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
<!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
<ItemGroup>
<_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues.rsp" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_mac.rsp" Condition="'$(TargetOS)' == 'OSX'" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
<_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ public static partial class PlatformDetection
public static bool IsArgIteratorNotSupported => !IsArgIteratorSupported;
public static bool Is32BitProcess => IntPtr.Size == 4;

// Please make sure that you have the libgdiplus dependency installed.
// For details, see https://docs.microsoft.com/dotnet/core/install/dependencies?pivots=os-macos&tabs=netcore31#libgdiplus
public static bool IsDrawingSupported
{
get
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Microsoft.VisualBasic.Tests
public class ErrObjectTests
{
[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/14854", TestRuntimes.Mono)]
public void Clear()
{
ProjectData.ClearProjectError();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ public static IEnumerable<object[]> IIf_TestData()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
public void DeleteSetting()
{
if (!PlatformDetection.IsInAppContainer)
Expand Down Expand Up @@ -207,6 +208,7 @@ private static (string, string)[] GetEnvironmentVariables()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
public void GetAllSettings()
{
if (!PlatformDetection.IsInAppContainer)
Expand All @@ -221,6 +223,7 @@ public void GetAllSettings()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
public void GetSetting()
{
if (!PlatformDetection.IsInAppContainer)
Expand Down Expand Up @@ -301,14 +304,14 @@ public void Partition_Overflow(long Number, long Start, long Stop, long Interval
{
Assert.Throws<OverflowException>(() => Interaction.Partition(Number, Start, Stop, Interval));
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
public void SaveSetting()
{
if (!PlatformDetection.IsInAppContainer)
{
Assert.Throws<ArgumentException>(() => Interaction.SaveSetting(AppName: "", Section: "", Key: "", Setting: ""));

}
else
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ public void IEnumerable_GetAllExpectedItems()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16413", TestRuntimes.Mono)]
public void ReferenceTypes_NulledAfterDequeue()
{
int iterations = 10; // any number <32 will do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ public void Ctor_Int(int capacity)
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/14858", TestRuntimes.Mono)]
public void Ctor_NegativeCapacity_ThrowsArgumentOutOfRangeException()
{
AssertExtensions.Throws<ArgumentOutOfRangeException>("capacity", () => new NameValueCollection(-1));
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Xunit;

[assembly: SkipOnMono("System.ComponentModel.Composition.Registration APIs are not supported on this platform")]
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<TargetFrameworks>$(NetCoreAppCurrent)</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<Compile Include="AssemblyInfo.cs" />
<Compile Include="InternalCalls.cs" />
<Compile Include="System\ComponentModel\Composition\Registration\ExportBuilderTests.cs" />
<Compile Include="System\ComponentModel\Composition\Registration\ExportBuilderUnitTests.cs" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Xunit;

[assembly: SkipOnMono("Flaky tests: https://github.com/mono/mono/issues/16417")]
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
<Compile Include="$(CommonTestPath)System\IO\TempFile.cs">
<Link>Common\System\IO\TempFile.cs</Link>
</Compile>
<Compile Include="AssemblyInfo.cs" />
<Compile Include="IMetadataView.cs" />
<Compile Include="MetadataTests_IMetadataView.cs" />
<Compile Include="System\LazyHelper.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public interface ITrans_CollectionOfStrings
public class AdvancedValueComposition
{
[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void RepeatedContainerUse()
{
var container = ContainerFactory.Create();
Expand All @@ -41,6 +42,7 @@ public void RepeatedContainerUse()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void FunctionsFieldsAndProperties()
{
Consumer c;
Expand All @@ -55,6 +57,7 @@ public void FunctionsFieldsAndProperties()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void FunctionsFieldsAndProperties2()
{
Consumer c;
Expand Down Expand Up @@ -252,6 +255,7 @@ public void ImportIntoUntypedExportTest()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportIntoDerivationOfExportException()
{
var container = ContainerFactory.Create();
Expand All @@ -269,6 +273,7 @@ public void ImportIntoDerivationOfExportException()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportIntoDerivationOfExportsException()
{
var container = ContainerFactory.Create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@

namespace System.ComponentModel.Composition
{
// [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public class AllowNonPublicCompositionTests
{
[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PublicFromPublic()
{
var container = ContainerFactory.Create();
Expand All @@ -25,6 +27,7 @@ public void PublicFromPublic()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PublicToSelf()
{
var container = ContainerFactory.Create();
Expand All @@ -38,6 +41,7 @@ public void PublicToSelf()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PublicFromPrivate()
{
var container = ContainerFactory.Create();
Expand All @@ -52,6 +56,7 @@ public void PublicFromPrivate()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PrivateFromPublic()
{
var container = ContainerFactory.Create();
Expand All @@ -66,6 +71,7 @@ public void PrivateFromPublic()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PrivateToSelf()
{
var container = ContainerFactory.Create();
Expand All @@ -79,6 +85,7 @@ public void PrivateToSelf()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void PrivateData()
{
var container = ContainerFactory.Create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

namespace System.ComponentModel.Composition.AttributedModel
{
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public class AttributedModelCompositionTests
{
[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ namespace System.ComponentModel.Composition.AttributedModel
public class AttributedModelDiscoveryTests
{
[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_TypeWithExports_ShouldHaveMultipleExports()
{
var definition = CreateDefinition(typeof(PublicComponentWithPublicExports));
Expand All @@ -34,6 +35,7 @@ public class DerivedClassWithInheritedPropertyExports : BaseClassWithPropertyExp
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_TypeWithImports_ShouldHaveMultipleImports()
{
var definition = CreateDefinition(typeof(PublicImportsExpectingPublicExports));
Expand Down Expand Up @@ -156,6 +158,7 @@ public void CreatePartDefinition_MultipleMarkedConstructorsAsPartTypeArgument_Sh
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked()
{
var definition = CreateDefinition(typeof(SimpleConstructorInjectedObject));
Expand All @@ -167,6 +170,7 @@ public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldS
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldSetConstructorToDefault()
{
var definition = CreateDefinition(typeof(PublicComponentWithPublicExports));
Expand All @@ -179,6 +183,7 @@ public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldS
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void CreatePartDefinition_OneMarkedAndOneDefaultConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked()
{
var definition = CreateDefinition(typeof(ClassWithOneMarkedAndOneDefaultConstructor));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public void OnImportsSatisfied()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportsSatisfiedOnComponentWithoutImports()
{
CompositionContainer container = ContainerFactory.CreateWithAttributedCatalog(typeof(PartWithoutImports));
Expand All @@ -35,6 +36,7 @@ public void ImportsSatisfiedOnComponentWithoutImports()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportCompletedTest()
{
var container = ContainerFactory.Create();
Expand All @@ -56,6 +58,7 @@ public void ImportCompletedTest()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportCompletedWithRecomposing()
{
var container = ContainerFactory.Create();
Expand Down Expand Up @@ -94,6 +97,7 @@ public void ImportCompletedWithRecomposing()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportCompletedAddPartAndBindComponent()
{
var container = ContainerFactory.Create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ public void Imports_Throws_OnNullContractName()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void Imports()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand All @@ -158,6 +159,7 @@ public void Imports()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void Imports_CardinalityIgnored_WhenNotSpecified()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand All @@ -170,6 +172,7 @@ public void Imports_CardinalityIgnored_WhenNotSpecified()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void Imports_CardinalityNotIgnored_WhenSpecified()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand Down Expand Up @@ -200,6 +203,7 @@ public void ImportsGeneric_Throws_OnNullPart()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportsGeneric()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand All @@ -213,6 +217,7 @@ public void ImportsGeneric()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand All @@ -225,6 +230,7 @@ public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void ImportsGeneric_CardinalityNotIgnored_WhenSpecified()
{
ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public void GetValuesTest()
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public void NoResolverExceptionTest()
{
var container = ContainerFactory.Create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

namespace System.ComponentModel.Composition
{
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public class CompositionContainerCollectionTests
{
public class SupportedImportCollectionAssignments<T>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

namespace System.ComponentModel.Composition
{
[ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
public class CompositionContainerImportTests
{
// Exporting collectin values is not supported
Expand Down
Loading

0 comments on commit b74422f

Please sign in to comment.