Ensure the IBinaryInteger.RotateLeft/Right DIMs use unsigned right sh…

…ift (#98119) * Adding tests covering DIMs for signed and unsigned binary integers * Ensure the IBinaryInteger.RotateLeft/Right DIMs use unsigned right shift
dotnet · Feb 8, 2024 · 9367edc · 9367edc
1 parent edf4ae8
commit 9367edc
Show file tree

Hide file tree

Showing 2 changed files with 400 additions and 2 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Numerics/IBinaryInteger.cs b/src/libraries/System.Private.CoreLib/src/System/Numerics/IBinaryInteger.cs
@@ -143,7 +143,7 @@ static virtual TSelf RotateLeft(TSelf value, int rotateAmount)
             }
 
             int bitCount = checked(value!.GetByteCount() * 8);
-            return (value << rotateAmount) | (value >> (bitCount - rotateAmount));
+            return (value << rotateAmount) | (value >>> (bitCount - rotateAmount));
         }
 
         /// <summary>Rotates a value right by a given amount.</summary>
@@ -158,7 +158,7 @@ static virtual TSelf RotateRight(TSelf value, int rotateAmount)
             }
 
             int bitCount = checked(value!.GetByteCount() * 8);
-            return (value >> rotateAmount) | (value << (bitCount - rotateAmount));
+            return (value >>> rotateAmount) | (value << (bitCount - rotateAmount));
         }
 
         /// <summary>Computes the number of trailing zero bits in a value.</summary>