Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[wasm][debugger] Reuse debugger-agent on wasm debugger (#52300)
* Trying to reuse debugger-agent on wasm debugger. This will remove a lot of code that does the same thing on mini-wasm-debugger. * Replace remove_breakpoint and clear_all_breakpoints with the ones on debugger-agent and remove unused code. * Stepping and callstack using debugger-agent. * Remove more code. * Get frame values using debugger-agent. * Working valuetypes and call function on valuetypes. make -C src/mono/wasm/ run-debugger-tests TEST_FILTER=DebuggerTests.SteppingTests.InspectValueTypeMethodArgsWhileStepping is working without use_cfo. * Failed: 316, Passed: 175 * Failed: 307, Passed: 184, Skipped: 0, Total: 491 * Failed: 280, Passed: 211 * Failed: 277, Passed: 214 * Implemented boxed value. Failed: 271, Passed: 220 * Implementing get properties on objects. Implementing handling error on debugger-agent. * Implementing callfunctionon object. Failed: 248, Passed: 243 * Implementing get pointer values. Failed: 243, Passed: 248 * Fixing pointer values and implement call on function with pointers. Failed: 226, Passed: 265 * Reimplement call function on, and implement set values. Failed: 192, Passed: 299 * Failed: 192, Passed: 299 * Fixing valuetype with null values. Failed: 184, Passed: 307 * Implemented Evaluate expressions, conditional breakpoints, all breakpoints tests are passing. Failed: 172, Passed: 319 * Fixing evaluate with value type. Failed: 156, Passed: 335 * Trim part and add cache. Failed: 148, Passed: 343 * Fixing evaluate expression. Failed: 99, Passed: 392 * GetPropertiesTests working. Failed: 53, Passed: 438 * Passing delegate tests. Failed: 31, Passed: 460 * Removing unused code. * Implementing exception handler. Failed: 30, Passed: 461 * Fixing cfo returning array. Removing more code. Removing 2 tests that tests functions which does not exist anymore. Failed: 18, Passed: 471 * Fix CallFunctionOn returning primitive types and null. Failed: 9, Passed: 480 * Failed: 7, Passed: 482 * Fixing some tests. Failed: 2, Passed: 488 * Removing a lot of code. Failed: 4, Passed: 485 * 0 ERRORS! * Removing more code. No errors. * Fixing added tests. * Return javascript callstack after managed callstack. Step out from managed code return to native wasm or javascript. Adding debug info to Wasm.Browser.Sample to help testing debugger with sample. * Change what Ankit suggested. Clear cache with valuetypes and pointers after resume or step. * Fixing suggestions. * Fix error on wasm build. * Apply suggestions from code review Co-authored-by: Larry Ewing <[email protected]> * Changing what was suggested by @lewing. * Fix pointer tests. * Refactoring CreateJObjectForVariableValue * Changing what @lewing suggested. * Apply suggestions from code review Co-authored-by: Larry Ewing <[email protected]> * Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs Co-authored-by: Larry Ewing <[email protected]> * Update src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Co-authored-by: Larry Ewing <[email protected]> * Fixing @lewing changes. * Trying to fix CI. Co-authored-by: Larry Ewing <[email protected]>
- Loading branch information