Skip to content

Commit

Permalink
Use shared IValueTaskSource implementation in AwaitableSocketAsyncEve…
Browse files Browse the repository at this point in the history
…ntArgs (#82147)

The upside here is we don't need a dedicated implementation with complicated logic inside of Socket.  The downside is this effectively increases the allocation for a Socket by a few fields, as the shared implementation has a few extra fields that go unused.
  • Loading branch information
stephentoub authored Mar 2, 2023
1 parent 0d16da9 commit 4d0a133
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 208 deletions.
3 changes: 0 additions & 3 deletions src/libraries/System.Net.Sockets/src/Resources/Strings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,6 @@
<data name="InvalidOperation_IncorrectToken" xml:space="preserve">
<value>The result of the operation was already consumed and may not be used again.</value>
</data>
<data name="InvalidOperation_MultipleContinuations" xml:space="preserve">
<value>Another continuation was already registered.</value>
</data>
<data name="net_sockets_sendpackelement_FileStreamMustBeAsync" xml:space="preserve">
<value>The FileStream must have been opened for asynchronous reading and writing.</value>
</data>
Expand Down
Loading

0 comments on commit 4d0a133

Please sign in to comment.