Check if global instance is registered

dotnet · Mar 12, 2020 · 234c733 · 234c733
1 parent dad304e
commit 234c733
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 12 deletions.
diff --git a/src/coreclr/src/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.cs b/src/coreclr/src/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.cs
@@ -289,6 +289,14 @@ public void RegisterAsGlobalInstance()
             }
         }
 
+        /// <summary>
+        /// Get whether or not a global <see cref="ComWrappers" /> instance has been registered.
+        /// </summary>
+        internal static bool IsGlobalInstanceRegistered()
+        {
+            return s_globalInstance != null;
+        }
+
         /// <summary>
         /// Get the runtime provided IUnknown implementation.
         /// </summary>

diff --git a/src/coreclr/src/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs b/src/coreclr/src/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs
@@ -331,10 +331,15 @@ public static string GetTypeInfoName(ITypeInfo typeInfo)
                 throw new ArgumentNullException(nameof(o));
             }
 
-            // Passing null as the ComWrapper implementation will use the globally registered wrappper (if available)
-            IntPtr ptrMaybe;
-            if (ComWrappers.TryGetOrCreateComInterfaceForObjectInternal(impl: null, o, CreateComInterfaceFlags.TrackerSupport, out ptrMaybe))
-                return ptrMaybe;
+            if (ComWrappers.IsGlobalInstanceRegistered())
+            {
+                // Passing null as the ComWrapper implementation will use the globally registered wrappper (if available)
+                IntPtr ptrMaybe;
+                if (ComWrappers.TryGetOrCreateComInterfaceForObjectInternal(impl: null, o, CreateComInterfaceFlags.TrackerSupport, out ptrMaybe))
+                {
+                    return ptrMaybe;
+                }
+            }
 
             return GetIUnknownForObjectNative(o, false);
         }
@@ -420,10 +425,15 @@ public static object GetObjectForIUnknown(IntPtr /* IUnknown* */ pUnk)
                 throw new ArgumentNullException(nameof(pUnk));
             }
 
-            // Passing null as the ComWrapper implementation will use the globally registered wrappper (if available)
-            object? objMaybe;
-            if (ComWrappers.TryGetOrCreateObjectForComInstanceInternal(impl: null, pUnk, CreateObjectFlags.TrackerObject, wrapperMaybe: null, out objMaybe))
-                return objMaybe!;
+            if (ComWrappers.IsGlobalInstanceRegistered())
+            {
+                // Passing null as the ComWrapper implementation will use the globally registered wrappper (if available)
+                object? objMaybe;
+                if (ComWrappers.TryGetOrCreateObjectForComInstanceInternal(impl: null, pUnk, CreateObjectFlags.TrackerObject, wrapperMaybe: null, out objMaybe))
+                {
+                    return objMaybe!;
+                }
+            }
 
             return GetObjectForIUnknownNative(pUnk);
         }
@@ -438,10 +448,15 @@ public static object GetUniqueObjectForIUnknown(IntPtr unknown)
                 throw new ArgumentNullException(nameof(unknown));
             }
 
-            // Passing null as the ComWrapper implementation will use the globally registered wrappper (if available)
-            object? objMaybe;
-            if (ComWrappers.TryGetOrCreateObjectForComInstanceInternal(impl: null, unknown, CreateObjectFlags.TrackerObject | CreateObjectFlags.UniqueInstance, wrapperMaybe: null, out objMaybe))
-                return objMaybe!;
+            if (ComWrappers.IsGlobalInstanceRegistered())
+            {
+                // Passing null as the ComWrapper implementation will use the globally registered wrappper (if available)
+                object? objMaybe;
+                if (ComWrappers.TryGetOrCreateObjectForComInstanceInternal(impl: null, unknown, CreateObjectFlags.TrackerObject | CreateObjectFlags.UniqueInstance, wrapperMaybe: null, out objMaybe))
+                {
+                    return objMaybe!;
+                }
+            }
 
             return GetUniqueObjectForIUnknownNative(unknown);
         }