AddRegsetForType()

dotnet · May 29, 2024 · 147a88b · 147a88b
1 parent 535c2e1
commit 147a88b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/src/coreclr/jit/lsra.cpp b/src/coreclr/jit/lsra.cpp
@@ -5221,13 +5221,13 @@ void LinearScan::allocateRegistersMinimal()
                 }
 #endif // TARGET_ARM
             }
-            regsInUseThisLocation |= currentRefPosition.registerAssignment;
+            regsInUseThisLocation.AddRegsetForType(currentRefPosition.registerAssignment, regRecord->registerType);
             INDEBUG(dumpLsraAllocationEvent(LSRA_EVENT_FIXED_REG, nullptr, currentRefPosition.assignedReg()));
 
 #ifdef SWIFT_SUPPORT
             if (currentRefPosition.delayRegFree)
             {
-                regsInUseNextLocation |= currentRefPosition.registerAssignment;
+                regsInUseNextLocation.AddRegsetForType(currentRefPosition.registerAssignment, regRecord->registerType);
             }
 #endif // SWIFT_SUPPORT
             continue;
@@ -5932,13 +5932,13 @@ void LinearScan::allocateRegisters()
                 }
 #endif // TARGET_ARM
             }
-            regsInUseThisLocation |= currentRefPosition.registerAssignment;
+            regsInUseThisLocation.AddRegsetForType(currentRefPosition.registerAssignment, regRecord->registerType);
             INDEBUG(dumpLsraAllocationEvent(LSRA_EVENT_FIXED_REG, nullptr, currentRefPosition.assignedReg()));
 
 #ifdef SWIFT_SUPPORT
             if (currentRefPosition.delayRegFree)
             {
-                regsInUseNextLocation |= currentRefPosition.registerAssignment;
+                regsInUseNextLocation.AddRegsetForType(currentRefPosition.registerAssignment, regRecord->registerType);
             }
 #endif // SWIFT_SUPPORT
             continue;

diff --git a/src/coreclr/jit/regMaskTPOps.cpp b/src/coreclr/jit/regMaskTPOps.cpp
@@ -108,6 +108,23 @@ void regMaskTP::AddRegNum(regNumber reg, var_types type)
 #endif
 }
 
+//------------------------------------------------------------------------
+// AddRegsetForType: Add regs of `type` in mask.
+//
+// Parameters:
+//  maskToAdd  - Register to check
+//  type       - type of register
+//
+void regMaskTP::AddRegsetForType(SingleTypeRegSet regs, var_types type)
+{
+#ifdef HAS_MORE_THAN_64_REGISTERS
+    int index = getRegisterTypeIndex(type);
+    _registers[index] |= encodeForRegisterIndex(index, regs);
+#else
+    low |= regs;
+#endif
+}
+
 //------------------------------------------------------------------------
 // IsRegNumInMask: Checks if `reg` is in the mask
 //

diff --git a/src/coreclr/jit/target.h b/src/coreclr/jit/target.h
@@ -283,6 +283,7 @@ struct regMaskTP
     void AddGprRegs(SingleTypeRegSet gprRegs);
     void AddRegNum(regNumber reg, var_types type);
     void AddRegNumInMask(regNumber reg);
+    void AddRegsetForType(SingleTypeRegSet maskToAdd, var_types type);
     void RemoveRegNum(regNumber reg, var_types type);
     void RemoveRegNumFromMask(regNumber reg);    
     bool IsRegNumInMask(regNumber reg) const;