-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Nullable annotations for System.Security.Cryptography.Xml (#67198)
* First pass * More annotations * Rever mistaken change to test * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * Remove red flag comment * PR feedback * Remove 'red flag' comments * Revert unintended changes to tests * Revert unintended changes * PR feedback: remove redundant !'s from things that can never return null * Added `[MemberNotNullWhen(true, nameof(_cachedXml))]` on implementation. * Updated ref t ypes (with `dotnet msbuild /t:GenerateReferenceAssemblySource`) * Updated ref assembly * PR feedback: add `MemberNotNull` attribute on `Initialize`) * Updated ref again * Put `MemberNotNull` attribute on the getter rather than the property in the reference file. * PR feedback: remove MemberNotNullWhenAttribute from ref * PR feedback: non nullable param to match method in base class * Fix post-merge build errors * PR feedback * PR feedback from @bartonjs - add [DisallowNull] and cascade * PR feedback * PR feedback * PR feedback * Fix build again, by removing the `protected internal` property `CacheValid` * PR feedback * Added back `CacheValid` based on PR comment * Fix issues from recent rebase * Add `DisallowNull` attribute to ref file and remove it from `DefaultGenApiDocIds.txt` * PR feedback * Fix issues from recent merge * Remove some more extraneous damnit operators * Fix NRT analysis errors after prior rebase * PR feedback * PR feedback * PR feedback * PR feedback * PR feedback * CipherReference and CipherValue made to disallow null * Make Uri non-nullable on EnctrypedReference * Add AllowNull attribute on EncryptedType::KeyInfo * AllowNull on EncryptedXml::Recipient * Made baseUri nullable * DisallowNull on PropertlyElement * AllowNull on SignedInfo::CanonicalizationMethod * AllowNull on SignedXml::EncryptedXml * Fix build after recent rebase * Remove redundant damnit operator now that #71860 has been merged * PR feedback * Fix build due to change of the CanonicalXmlElement constructor * PR feedback * Remove redundant damnit operators * Fix broken tests * Fix issues after rebase * PR feedback * PR feedback
- Loading branch information
Showing
63 changed files
with
845 additions
and
795 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
182 changes: 95 additions & 87 deletions
182
src/libraries/System.Security.Cryptography.Xml/ref/System.Security.Cryptography.Xml.cs
Large diffs are not rendered by default.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
src/libraries/System.Security.Cryptography.Xml/ref/System.Security.Cryptography.Xml.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.