-
Notifications
You must be signed in to change notification settings - Fork 60
Add TestData project containing Unicode UCD files #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TestData project containing Unicode UCD files #44
Conversation
|
Yes we need a THIRD-PARTY-NOTICES.TXT. Please see 2a90188 for an example.
You decide on the name :) |
|
@ViktorHofer I didn't even see that notices file under the project folder. Should I also throw this one under the new project folder (which I guess means it gets swept up as part of the nupkg?), or do we want to move it to the repo root? |
|
I think we should move it to the repo root and include your notice. I think it being part of the package was a mistake. |
|
Ok, I'll fix it up when I'm back in the office. |
|
Changes in most recent iteration:
|
|
What about |
src/Microsoft.Private.UnicodeData/Microsoft.Private.UnicodeData.csproj
Outdated
Show resolved
Hide resolved
src/System.IO.Compression.TestData/System.IO.Compression.TestData.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Private.Runtime.UnicodeData/Microsoft.Private.Runtime.UnicodeData.csproj
Outdated
Show resolved
Hide resolved
|
/azp run runtime-assets |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo is now ready. Feel free to merge after addressing my last comment :) I'm still not 100% sure about the package name. Looping in a few other folks who might be interested: @akoeplinger @jkotas
|
System.Private.* works for me. :) |
This contains the Unicode data files that are needed by dotnet/runtime#328. I followed steps 1 - 3 in the README and verified that this package can be consumed by our test projects.
Open questions:
Do we really want to name this
Private.CoreFx.TestUtilities.Unicode.TestData? It will eventually be consumed by several unit projects, including Private.CoreFx.TestUtilities.Unicode, System.Globalization.Tests, and System.Text.Encodings.Web.Tests. (I'll need to make a minor change to this and bump the version to 1.0.1 before that last project can consume it.)Do we need
THIRD-PARTY-NOTICES.TXT? These files are copied from https://www.unicode.org/Public/, and we have a similar notices file in the runtime repo.