Repository navigation
[CLI] Make analyzer type loading resilient and log System.Composition redirects - #1842
Merged
Merged
Conversation
… redirects - Skip analyzer and code fix provider types whose attributes or instance cannot be loaded instead of aborting the whole run. - Log each System.Composition redirect at diagnostic verbosity. - Rename AnalyzerDependencyResolver to CompositionAssemblyResolver, drop the _isRegistered guard and use a collection expression. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1831.
FileNotFoundException,FileLoadException,BadImageFormatException,TypeLoadException) instead of aborting the whole run. Details are logged at diagnostic verbosity.System.Compositionredirect at diagnostic verbosity.AnalyzerDependencyResolvertoCompositionAssemblyResolver(avoids confusion withAnalyzerAssemblyLoader), remove the_isRegisteredguard, use a collection expression.No changelog entry.
Made with Cursor