fix(cli): omit internal interfaces in generate-doc output - #1801
Merged
Conversation
Fixes #1635 Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
commented
Aug 11, 2026
josefpihrt
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review notes for omitting restrictive interfaces from generate-doc. The accessibility filter matches #1635; a couple of cleanup/test notes.
Co-authored-by: Cursor <cursoragent@cursor.com>
…lter Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Use the existing public-API visibility check instead of comparing declared accessibility, and drop the Documentation.Tests project added for the previous helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
commented
Aug 14, 2026
josefpihrt
commented
Aug 14, 2026
Keep generate-doc on IsPubliclyVisible without hardcoding public-only in the shared list-symbols display path. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 16, 2026
Open
This was referenced Aug 21, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-docwithIsPubliclyVisible()so internal (and otherwise non-public) interfaces are omitted from consumer-facing documentationGetDisplayPartstakes an optionalshouldDisplayInterfacecallback so list-symbols can still honor its own visibility filterpublic class Public : IInternalproducing links to internalIInternalin github and docusaurus outputFixes #1635
Test plan
dotnet build src/Documentation/Documentation.csprojdotnet build src/CommandLine/CommandLine.csproj