Fix RCS1118 to not report local variable passed as 'in' argument - #1782
Merged
Conversation
josefpihrt
requested changes
Aug 1, 2026
josefpihrt
left a comment
josefpihrt
left a comment
Collaborator
There was a problem hiding this comment.
Please update change log.
josefpihrt
approved these changes
Aug 1, 2026
Collaborator
|
@NoahStolk Thank you for your contribution! |
This was referenced Aug 8, 2026
Closed
Open
This was referenced Aug 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1781
RCS1118 reports a local variable that is later passed to a parameter with an explicit
inargument keyword. Marking such a local as const produces code that does not compile, because a constant cannot be passed by readonly reference.Added two new tests: one for an
inparameter and one for aref readonlyparameter. Both fail onmainand pass with the fix.