Fix analyzer RCS1060 - #1777
Merged
Merged
Conversation
* Ignore classes with ile modifier, because that expresses an explicit design choice which must be equivalent to ignoring the diagnostic
cbersch
marked this pull request as ready for review
July 8, 2026 06:39
josefpihrt
requested changes
Aug 1, 2026
Collaborator
|
@cbersch fix looks fine, I just added a couple of comments. |
josefpihrt
approved these changes
Aug 2, 2026
Collaborator
|
@cbersch Thank you for your contribution! |
This was referenced Aug 8, 2026
Closed
Open
This was referenced Aug 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filemodifier, because that expresses an explicit design choice which must be equivalent to ignoring the diagnostic.Fix RCS1060 fires even when I have an explicit
filescope modifier on a class. #1775