Fixed DeclareAsNullableCodeFixProvider for casts in variable declarations #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Casting a nullable type to a non-nullable type within a variable declaration no longer ignores the cast type and also no longer changes `var` to `var?`. Fixes dotnet#1392.
jroessel
force-pushed
the
declare-as-nullable-cast
branch
from
aec46da to
83f5bc8
Compare
Contributor
Author
|
@dotnet-policy-service agree company="yWorks GmbH" |
josefpihrt
requested changes
Feb 15, 2024
Collaborator
josefpihrt
left a comment
josefpihrt
left a comment
There was a problem hiding this comment.
Please update changelog.
src/CodeFixes/CSharp/CodeFixes/DeclareAsNullableCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/CodeFixes/CSharp/CodeFixes/DeclareAsNullableCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
src/CodeFixes/CSharp/CodeFixes/DeclareAsNullableCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
jroessel
force-pushed
the
declare-as-nullable-cast
branch
from
1cc4d1f to
a977ddd
Compare
josefpihrt
reviewed
Feb 17, 2024
josefpihrt
reviewed
Feb 17, 2024
josefpihrt
approved these changes
Feb 17, 2024
Collaborator
|
Thank you for the contribution @jroessel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting a nullable type to a non-nullable type within a variable declaration no longer ignores the cast type and also no longer changes
vartovar?.Fixes #1392.
The code got a little convoluted and the necessity to change two types at the same time required a separate method. I'm still not sure whether there's a good way of queuing two different fixes at the same time, as you can't find your syntax nodes anymore. I hope it's okay enough, though.