Add analyzer and fix provider RCS1265: Remove redundant catch statement #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefpihrt
requested changes
Jan 18, 2024
src/Analyzers/CSharp/Analysis/RemoveRedundantCatchBlockAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Analysis/RemoveRedundantCatchBlockAnalyzer.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I have revised the code based on your comments, thank you for them, I hope it is better now. |
josefpihrt
requested changes
Jan 19, 2024
src/Analyzers.CodeFixes/CSharp/CodeFixes/RemoveRedundantCatchBlockCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
@jakubreznak I'm glad that you took the initiative and implement the analyzer by yourself. I added some more comments and I think that after this iteration the PR could be merged. |
Contributor
Author
|
Now i understand and it is better starting analysis from try statement so i did it that way. Again thanks for your code review and your comments. |
josefpihrt
requested changes
Jan 19, 2024
Collaborator
josefpihrt
left a comment
josefpihrt
left a comment
There was a problem hiding this comment.
Please fix typo in file name "RCS1265RemoveRedundantCantchBlockTests.cs"
josefpihrt
approved these changes
Jan 21, 2024
Collaborator
|
@jakubreznak Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1025