Skip to content

Conversation

@josefpihrt
Copy link
Collaborator

No description provided.

@josefpihrt josefpihrt self-assigned this Oct 1, 2023
@AlmarAubel
Copy link

ohh yes this is great. I was building my own analyzer Roslynator.Testing.CSharp and tried to use a copy of AbstractCSharpDiagnosticVerifier but it was using a lot of internal functions it looks like I can now just use CompilerDiagnosticFixVerifier

@josefpihrt
Copy link
Collaborator Author

@AlmarAubel @nathanpovo If you have any comments please add it to this PR. Otherwise, the PR is ready to be merged.

@nathanpovo
Copy link

Thanks for your hard work @josefpihrt!

Managed to get some time to test this out. Had to add a reference to a local version of the Testing.Common and Testing.CSharp.Xunit project (it would not work with just a reference to the Testing.CSharp.Xunit project).

Didn't have the chance to do a proper test suite using the new package but it looks to be ok from the couple of tests I tried.

@josefpihrt josefpihrt merged commit 7eb8e16 into main Oct 18, 2023
@josefpihrt josefpihrt deleted the feature/testing-framework branch October 18, 2023 15:06
@AlmarAubel
Copy link

Thank you after creating a copy of AbstractCSharpDiagnosticVerifier I could use it on my own analyzers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants