Fix for RemoveRedundantToStringCall(RCS1097) #1037
Merged
josefpihrt merged 4 commits intodotnet:mainfrom Feb 26, 2023
Merged
Conversation
jamesHargreaves12
force-pushed
the
fix/RCS1097
branch
from
717b4f8 to
05ea380
Compare
josefpihrt
requested changes
Feb 14, 2023
src/Tests/Analyzers.Tests/RCS1097RemoveRedundantToStringCallTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Analyzers.Tests/RCS1097RemoveRedundantToStringCallTests.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
Hi, thanks for the PR, I just made some minor comments. |
…sts.cs Co-authored-by: Josef Pihrt <josef@pihrt.net>
…sts.cs Co-authored-by: Josef Pihrt <josef@pihrt.net>
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
Co-authored-by: Josef Pihrt <josef@pihrt.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behaviour:
It looks as if this was attempted to be prevented by using an IsReferenceType check at:
https://github.com/JosefPihrt/Roslynator/blob/3c6f1c1fc24b63aea6b0d82e64ec4e02d9ca39ad/src/Analyzers/CSharp/Analysis/RemoveRedundantToStringCallAnalysis.cs#L60
Unfortunately, this doesn't work for structs as they have type System.ValueType which is considered a reference type. See
https://learn.microsoft.com/en-us/dotnet/api/system.type.isvaluetype?redirectedfrom=MSDN&view=net-7.0#System_Type_IsValueType
Fix implemented just explicitly checks for
System_ValueType.Also added a test to catch future regressions.