Skip to content

Allow assigning a readonly static in another instantiation's static ctor for compat - #992

Merged
gafter merged 2 commits into
dotnet:masterfrom
gafter:fix990
Mar 4, 2015
Merged

Allow assigning a readonly static in another instantiation's static ctor for compat#992
gafter merged 2 commits into
dotnet:masterfrom
gafter:fix990

Conversation

@gafter

@gafter gafter commented Mar 3, 2015

Copy link
Copy Markdown
Member

Fixes #990

@gafter gafter self-assigned this Mar 3, 2015
@gafter gafter added this to the 1.0-rc2 milestone Mar 3, 2015
@gafter gafter added 4 - In Review A fix for the issue is submitted for review. and removed cla-not-required labels Mar 3, 2015
@gafter

gafter commented Mar 3, 2015

Copy link
Copy Markdown
Member Author

@jaredpar @VSadov @AlekseyTs @agocke @VladimirReshetnikov Could a couple of you review this please?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks wrong.

@VladimirReshetnikov

Copy link
Copy Markdown

👍

@AlekseyTs

Copy link
Copy Markdown
Contributor

LGTM

@AlekseyTs

Copy link
Copy Markdown
Contributor

Does Roslyn have the same behavior change in VB?

@gafter

gafter commented Mar 4, 2015

Copy link
Copy Markdown
Member Author

@AlekseyTs Yes; see #1028. However, given the slightly greater VB tolerance for breaking incorrect code, that may be the right place to land.

gafter added a commit that referenced this pull request Mar 4, 2015
Allow assigning a readonly static in another instantiation's static ctor for compat
@gafter
gafter merged commit d2650bb into dotnet:master Mar 4, 2015
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label Mar 4, 2015
@gafter
gafter deleted the fix990 branch March 11, 2015 23:21
jjonescz pushed a commit to jjonescz/roslyn that referenced this pull request Apr 28, 2026
dibarbet pushed a commit that referenced this pull request Aug 18, 2026
Verify refactoring tests specify the expected result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking change: C# can no longer assign to static readonly field of another instantiation

4 participants