Skip to content

Move some more rules to System.Runtime.Analyzers #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srivatsn merged 3 commits into from
Mar 4, 2015
Merged

Move some more rules to System.Runtime.Analyzers #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4e135f
Moving CA2231 to System.Rutime.Analyzers and adding a fixer for it.
srivatsn Feb 27, 2015
a37e6c4
merge from upstream/master.
srivatsn Feb 27, 2015
4dae4d7
Move CA1014, CA1016 and CA1017 to System.Runtime.Analyzers. These rul…
srivatsn Feb 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Diagnostics/FxCop/CSharp/CSharpFxCopRulesDiagnosticAnalyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
<Compile Include="Performance\CSharpCA1821DiagnosticAnalyzer.cs" />
<Compile Include="Reliability\CSharpCA2002DiagnosticAnalyzer.cs" />
<Compile Include="Usage\CodeFixes\CA2213CSharpCodeFixProvider.cs" />
<Compile Include="Usage\CodeFixes\CA2231CSharpCodeFixProvider.cs" />
<Compile Include="Usage\CodeFixes\CA2235CSharpCodeFixProvider.cs" />
<Compile Include="Usage\CSharpCA2200DiagnosticAnalyzer.cs" />
<Compile Include="Usage\CSharpCA2213DiagnosticAnalyzer.cs" />
Expand Down
96 changes: 0 additions & 96 deletions src/Diagnostics/FxCop/CSharp/Usage/CodeFixes/CA2231CSharpCodeFixProvider.cs
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions src/Diagnostics/FxCop/Core/FxCopFixersResources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions src/Diagnostics/FxCop/Core/FxCopFixersResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="OverloadOperatorEqualsOnOverridingValueTypeEquals" xml:space="preserve">
<value>Overload operator equals on overriding ValueType.Equals</value>
</data>
<data name="AvoidUnsealedAttributesCodeFix" xml:space="preserve">
<value>Seal attribute type.</value>
</data>
Expand Down
4 changes: 0 additions & 4 deletions src/Diagnostics/FxCop/Core/FxCopRulesDiagnosticAnalyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,9 @@
<Compile Include="AbstractNamedTypeAnalyzer.cs" />
<Compile Include="CodeFixProviderBase.cs" />
<Compile Include="DiagnosticCustomTags.cs" />
<Compile Include="Design\AssemblyAttributesDiagnosticAnalyzer.cs" />
<Compile Include="Design\CA1003DiagnosticAnalyzer.cs" />
<Compile Include="Design\CA1008DiagnosticAnalyzer.cs" />
<Compile Include="Design\CA1012DiagnosticAnalyzer.cs" />
<Compile Include="Design\CA1017DiagnosticAnalyzer.cs" />
<Compile Include="Design\CA1024DiagnosticAnalyzer.cs" />
<Compile Include="Design\CA1060DiagnosticAnalyzer.cs" />
<Compile Include="Design\CodeFixes\CA1008CodeFixProviderBase.cs" />
Expand Down Expand Up @@ -156,10 +154,8 @@
<Compile Include="Usage\CA2200DiagnosticAnalyzer.cs" />
<Compile Include="Usage\CA2213DiagnosticAnalyzer.cs" />
<Compile Include="Usage\CA2214DiagnosticAnalyzer.cs" />
<Compile Include="Usage\CA2231DiagnosticAnalyzer.cs" />
<Compile Include="Usage\CodeFixes\CA2213CodeFixProviderBase.cs" />
<Compile Include="Usage\CodeFixes\CA2229CodeFixProvider.cs" />
<Compile Include="Usage\CodeFixes\CA2231CodeFixProviderBase.cs" />
<Compile Include="Usage\CodeFixes\CA2235CodeFixProviderBase.cs" />
<Compile Include="Usage\CodeFixes\CA2237CodeFixProvider.cs" />
<Compile Include="Usage\SerializationRulesDiagnosticAnalyzer.cs" />
Expand Down
81 changes: 0 additions & 81 deletions src/Diagnostics/FxCop/Core/FxCopRulesResources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 0 additions & 27 deletions src/Diagnostics/FxCop/Core/FxCopRulesResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@
<data name="TypeOwnsDisposableFieldButIsNotDisposable" xml:space="preserve">
<value>Type '{0}' owns disposable fields but is not disposable</value>
</data>
<data name="OverloadOperatorEqualsOnOverridingValueTypeEquals" xml:space="preserve">
<value>Overload operator equals on overriding ValueType.Equals</value>
</data>
<data name="TypeIsAbstractButHasPublicConstructors" xml:space="preserve">
<value>Type '{0}' is abstract but has public constructors</value>
</data>
Expand Down Expand Up @@ -156,12 +153,6 @@
<data name="SerializationCtorAccessibilityForUnSealedType" xml:space="preserve">
<value>Declare serialization constructor for unsealed type {0} as protected</value>
</data>
<data name="AssembliesShouldBeMarkedWithAssemblyVersionAttribute" xml:space="preserve">
<value>Assemblies should be marked with AssemblyVersionAttribute</value>
</data>
<data name="MarkAssembliesWithCLSCompliantAttribute" xml:space="preserve">
<value>Mark assemblies with CLSCompliantAttribute</value>
</data>
<data name="DisposableFieldsShouldBeDisposed" xml:space="preserve">
<value>Disposable fields should be disposed</value>
</data>
Expand Down Expand Up @@ -234,18 +225,9 @@
<data name="AbstractTypesShouldNotHavePublicConstructorsCodeFix" xml:space="preserve">
<value>Change the accessibility of all public contructors in this class to protected.</value>
</data>
<data name="CA1017_NoAttribute" xml:space="preserve">
<value>Because {0} exposes externally visible types, mark it with ComVisible(false) at the assembly level and then mark all types within the assembly that should be exposed to COM clients with ComVisible(true).</value>
</data>
<data name="CA1017_AttributeTrue" xml:space="preserve">
<value>Consider changing the ComVisible attribute on {0} to false, and opting in at the type level.</value>
</data>
<data name="IdentifiersShouldDifferByMoreThanCase" xml:space="preserve">
<value>Identifier names should differ by more than case</value>
</data>
<data name="MarkAllAssembliesWithComVisible" xml:space="preserve">
<value>Mark all assemblies with ComVisible</value>
</data>
<data name="AbstractTypesShouldNotHavePublicConstructors" xml:space="preserve">
<value>Abstract classes should not have public constructors</value>
</data>
Expand Down Expand Up @@ -276,9 +258,6 @@
<data name="EnumsShouldHaveZeroValueDescription" xml:space="preserve">
<value>An enum should generally have a zero value. If the enum is not decorated with the Flags attribute, it should have a member with a value of zero that represents the empty state. Optionally, this value is named 'None'. For a Flags-attributed enum, a zero-valued member is optional and, if it exists, should always be named 'None'. This value should indicate that no values have been set in the enum. Using a zero-valued member for other purposes is contrary to the use of the Flags attribute in that the bitwise AND and OR operators are useless with the member.</value>
</data>
<data name="MarkAllAssembliesWithComVisibleDescription" xml:space="preserve">
<value>The System.Runtime.InteropServices.ComVisible attribute indicates whether COM clients can use the library. Good design dictates that developers explicitly indicate COM visibility. The default value for this attribute is 'true'. However, the best design is to mark the assembly ComVisible false, and then mark types, interfaces, and individual members as ComVisible true, as appropriate.</value>
</data>
<data name="UsePropertiesWhereAppropriateDescription" xml:space="preserve">
<value>Properties should be used instead of Get/Set methods in most situations. Methods are preferable to properties in the following situations: the operation is a conversion, is expensive or has an observable side-effect; the order of execution is important; calling the member twice in succession creates different results; a member is static but returns a mutable value; or the member returns an array.</value>
</data>
Expand All @@ -297,18 +276,12 @@
<data name="MarkAllNonSerializableFieldsDescription" xml:space="preserve">
<value>All fields that cannot be serialized directly should have the NonSerializedAttribute. Types that have the SerializableAttribute should not have fields of types that do not have the SerializableAttribute unless the fields are marked with the NonSerializedAttribute.</value>
</data>
<data name="MarkAssembliesWithCLSCompliantDescription" xml:space="preserve">
<value>Assemblies should explicitly state their CLS compliance using the CLSCompliant attribute. An assembly without this attribute is not CLS-compliant. Assemblies, modules, and types can be CLS-compliant even if some parts of the assembly, module, or type are not CLS-compliant. The following rules apply: 1) If the element is marked CLSCompliant, any noncompliant members must have the CLSCompliant attribute present with its argument set to false. 2) A comparable CLS-compliant alternative member must be supplied for each member that is not CLS-compliant.</value>
</data>
<data name="MarkEnumsWithFlagsDescription" xml:space="preserve">
<value>The enumeration appears to be made up of combinable flags. If this true, apply the Flags attribute to the enumeration.</value>
</data>
<data name="MarkISerializableTypesWithAttributeDescription" xml:space="preserve">
<value>The System.Runtime.Serialization.ISerializable interface allows the type to customize its serialization, while the Serializable attribute enables the runtime to recognize the type as being serializable.</value>
</data>
<data name="OverloadOperatorEqualsOnOverridingValueTypeEqualsDescription" xml:space="preserve">
<value>Value types that redefine System.ValueType.Equals should redefine the equality operator as well to ensure that these members return the same results. This helps ensure that types that rely on Equals (such as ArrayList and Hashtable) behave in a manner that is expected and consistent with the equality operator.</value>
</data>
<data name="RemoveEmptyFinalizersDescription" xml:space="preserve">
<value>Finalizers should be avoided where possible, to avoid the additional performance overhead involved in tracking object lifetime.</value>
</data>
Expand Down
Loading