Skip to content

Unskip and fix test CS0030ERR_NoExplicitConv02 - #922

Merged
VladimirReshetnikov merged 1 commit into
dotnet:masterfrom
VladimirReshetnikov:fixCulture
Mar 9, 2015
Merged

Unskip and fix test CS0030ERR_NoExplicitConv02#922
VladimirReshetnikov merged 1 commit into
dotnet:masterfrom
VladimirReshetnikov:fixCulture

Conversation

@VladimirReshetnikov

Copy link
Copy Markdown

Unskip test CS0030ERR_NoExplicitConv02 and remove its dependency on the current culture.
Further error message improvement is tracked as issue #920.

@VladimirReshetnikov

Copy link
Copy Markdown
Author

@AlekseyTs @tmat @VSadov Please review.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the culture only for the duration of VerifyDiagnostics method, but we should request diagnostics before the culture is changed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlekseyTs Done.

@AlekseyTs

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@VSadov

VSadov commented Mar 9, 2015

Copy link
Copy Markdown
Member

LGTM

VladimirReshetnikov pushed a commit that referenced this pull request Mar 9, 2015
Unskip and fix test CS0030ERR_NoExplicitConv02
@VladimirReshetnikov
VladimirReshetnikov merged commit 9c9a01d into dotnet:master Mar 9, 2015
jjonescz pushed a commit to jjonescz/roslyn that referenced this pull request Apr 28, 2026
* Don't fail the build on warnings

* update

* update
dibarbet pushed a commit that referenced this pull request Aug 18, 2026
Fix long commands breaking component debugger:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants