Call DkmClrValue.Close more conservatively - #917
Merged
Conversation
Member
Author
|
FYI @KevinH-MS @cston @pnelsonmsft @ManishJayaswal |
Contributor
|
LGTM |
Contributor
|
👍 |
The problem arises when more than one expansion shares the same value - for example, those parented by a common AggregateExpansion. Since this is an optimization anyway (the debugger would eventually close them on its own), we'll just conservatively focus on data items without children. Fixes dotnet#901.
amcasey
added a commit
that referenced
this pull request
Feb 27, 2015
Call DkmClrValue.Close more conservatively
Contributor
There was a problem hiding this comment.
Should we close array element values of reference types?
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Extend AnalyzerTest to support tests for DiagnosticSuppressor analyzers
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem arises when more than one expanion shares the same value - for
example, those parented by a common AggregateExpansion. Since this is an
optimization anyway (the debugger would eventually close them on its own),
we'll just conservatively focus on member and array expensions, since they
always "own" the value in aggregate expansions.
Fixes #901.