Respect the ReferenceOutputAssembly flag - #902
Closed
jaredpar wants to merge 2 commits into
Closed
Conversation
The MSBuild workspace code should respect the ReferenceOutputAssembly flag. Before only the C# implementation of MSBuild was doing so. Now all implementations will properly respect the flag. closes dotnet#900
Member
Author
Contributor
|
👍 |
Member
There was a problem hiding this comment.
Can the virtualness go away here so this is less buggy? I see there's still some specific C# logic around handling of aliases, but can we have a virtual method for just that rather than a crazy override like this?
Member
Author
There was a problem hiding this comment.
There needs to be a virtual somewhere. It could be on the create side though.
Member
|
Tests? Otherwise 👍. |
Changed: - Added test cases for the regression. - Moved virtual logic to the actual creation of the ProjectFileReference node.
Member
Author
|
closed with cda0777 |
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Add package reference for System.Net.Http
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSBuild workspace code should respect the ReferenceOutputAssembly
flag. Before only the C# implementation of MSBuild was doing so. Now
all implementations will properly respect the flag.
closes #900