Skip to content

Add testing for the MSBuildTask. - #866

Closed
agocke wants to merge 1 commit into
dotnet:masterfrom
agocke:AddBuildTaskTesting
Closed

Add testing for the MSBuildTask.#866
agocke wants to merge 1 commit into
dotnet:masterfrom
agocke:AddBuildTaskTesting

Conversation

@agocke

@agocke agocke commented Feb 25, 2015

Copy link
Copy Markdown
Member

This change brings back the SimpleMSBuild test, which sets
up a "hello world" C#+VB solution and builds it using msbuild using
the build task.

Two build-task-specific tests have also been added, which directly
load and call execute on the Csc and Vbc tasks.

@AlekseyTs @VSadov @VladimirReshetnikov @gafter @jaredpar

@agocke

agocke commented Feb 25, 2015

Copy link
Copy Markdown
Member Author

@AlekseyTs @VSadov @VladimirReshetnikov @gafter @jaredpar Could you review this please?

@agocke

agocke commented Feb 26, 2015

Copy link
Copy Markdown
Member Author

retest this please

@jaredpar

Copy link
Copy Markdown
Member

@dotnet-bot retest this please

@jaredpar

Copy link
Copy Markdown
Member

@agocke think you have to ask the bot directly.

@agocke

agocke commented Feb 26, 2015

Copy link
Copy Markdown
Member Author

@jaredpar Idk, I think it was working.

@agocke agocke mentioned this pull request Feb 26, 2015
This change brings back the SimpleMSBuild test, which sets
up a "hello world" C#+VB solution and builds it using msbuild using
the build task.

Two build-task-specific tests have also been added, which directly
load and call execute on the Csc and Vbc tasks.
@agocke
agocke force-pushed the AddBuildTaskTesting branch from 5eaace0 to a93758d Compare February 26, 2015 19:18
@agocke

agocke commented Feb 27, 2015

Copy link
Copy Markdown
Member Author

Ping -- this one should be simple to review.

@jaredpar

Copy link
Copy Markdown
Member

👍

1 similar comment
@gafter

gafter commented Feb 27, 2015

Copy link
Copy Markdown
Member

👍

@agocke agocke closed this in 5c315e7 Feb 28, 2015
@agocke
agocke deleted the AddBuildTaskTesting branch March 3, 2015 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants