Skip to content

Follow-up to telemetry collection PR - #85254

Merged
akhera99 merged 2 commits into
dotnet:mainfrom
akhera99:follow_up_telemetry_test
Sep 10, 2026
Merged

Follow-up to telemetry collection PR#85254
akhera99 merged 2 commits into
dotnet:mainfrom
akhera99:follow_up_telemetry_test

Conversation

@akhera99

@akhera99 akhera99 commented Sep 10, 2026

Copy link
Copy Markdown
Member

follow-up to this comment: #85082 (comment)

Copilot AI lite review requested due to automatic review settings September 10, 2026 21:31
@akhera99
akhera99 requested a review from a team as a code owner September 10, 2026 21:31
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed changes are limited to test relocation and cleanup with no unresolved issues.

Review tier: Lite
Findings: None

What changed in this PR

Relocates the streamed-reference telemetry regression test to the references test suite.

Changes:

  • Moves the integration test.
  • Removes obsolete collections and imports.
File Description
src/​LanguageServer/​ProtocolUnitTests/​Telemetry/​RequestTelemetryLoggerTests.cs Removes the relocated test and unused dependencies.
src/​LanguageServer/​ProtocolUnitTests/​References/​FindAllReferencesHandlerTests.cs Adds the streamed-reference telemetry test.

Copilot AI review requested due to automatic review settings September 10, 2026 21:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The telemetry scope is installed after server startup, so the integration test may pass without observing the handler’s event.

Review tier: Lite
Findings: None

@akhera99
akhera99 enabled auto-merge (squash) September 10, 2026 22:11
@akhera99
akhera99 merged commit bd6ba8d into dotnet:main Sep 10, 2026
21 of 23 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the Next milestone Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants