Version EditorConfig VS components independently - #85250
Merged
Merged
Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update versioning for Visual Studio EditorConfig components
Version EditorConfig VS components independently, following Razor's scoped-versioning pattern
Sep 10, 2026
JoeRobich
approved these changes
Sep 10, 2026
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
JoeRobich
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Update the snap procedure to use the shared VS train properties.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This pull request gives EditorConfig VS components independent versioning while centralizing the shared Visual Studio train values used by EditorConfig and Razor tooling.
Changes:
- Adds shared VS train and EditorConfig version properties.
- Applies scoped
18.12.0versioning to EditorConfig projects. - Derives Razor versions from the shared VS train while preserving current values.
File summaries
| File | Description |
|---|---|
src/VisualStudio/EditorConfig/Directory.Build.props |
Applies EditorConfig-specific versioning to child projects. |
eng/Versions.props |
Defines shared VS, Razor, and EditorConfig version properties. Nit: Snap guidance should update the shared VsMajorVersion/VsMinorVersion properties rather than derived Razor properties. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidwengier
approved these changes
Sep 10, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a minor documentation nit was identified, and it does not block approval.
Review details
Suppressed comments (1)
.github/skills/snap/SKILL.md:724
- This updated follow-up instruction refers to
<Razor.RazorMajorVersion>, but the property defined ineng/Versions.propsis<RazorMajorVersion>. Please correct the placeholder so the snap workflow unambiguously identifies the Razor SDK major to match.
**Deferred Razor SDK version bump** (roslyn only): If the Razor SDK version bump (Phase 2 step 5) was deferred during the initial snap because no matching `.NET <Razor.RazorMajorVersion>.0.<Band>xx SDK` channel existed on `main` at the time, re-check now:
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
JoeRobich
enabled auto-merge (squash)
September 10, 2026 22:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditorConfig VS components (Command, Setup, Templates, Wizard, WizardSetup) currently inherit Roslyn's main assembly version instead of being versioned against the VS train, unlike Razor tooling which already has its own scoped version.
Common VS train properties
VsMajorVersion/VsMinorVersiontoeng/Versions.propsas the single source of truth for the current VS train.VsMajorVersionis calculated as RoslynMajorVersion + 13;VsMinorVersionis calculated from RoslynMinorVersion.5.12therefore produces VS train18.12.Razor tooling refactor
RazorVsixVersionPrefixandRazorAddinMajorVersionnow derive fromVsMajorVersion/VsMinorVersionplusRazorVsixPatchVersion(1), instead of hard-coding18.12.18.12.1for VSIX,18.12for addin, and the existing official/non-officialRazorAddinVersionlogic) are unchanged.EditorConfig versioning
EditorConfigPatchVersion(0),EditorConfigVersionPrefix(18.12.0), andEditorConfigAssemblyVersion(18.12.0.0) toeng/Versions.props.src/VisualStudio/EditorConfig/Directory.Build.props, scoping all projects under that directory to the EditorConfig version instead of Roslyn's.Snap workflow
VsMajorVersion,VsMinorVersion,RazorVsixVersionPrefix,RazorAddinMajorVersion, and EditorConfig version properties unchanged while continuing to update Razor SDK versions when channel mapping requires it.EditorConfig components version as
18.12.0while Razor tooling remains18.12.1, with both driven automatically by Roslyn's version.