Skip to content

Show progress during long code reviews - #85233

Merged
mwiemer-microsoft merged 3 commits into
mainfrom
mwiemer-review-status-output
Sep 9, 2026
Merged

Show progress during long code reviews#85233
mwiemer-microsoft merged 3 commits into
mainfrom
mwiemer-review-status-output

Conversation

@mwiemer-microsoft

@mwiemer-microsoft mwiemer-microsoft commented Sep 9, 2026

Copy link
Copy Markdown
Member

While running an agent session, I triggered a 20+ minute code review. I couldn't tell what the review agent was doing, so this PR adds a status log to review sessions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 9, 2026 21:37
@mwiemer-microsoft
mwiemer-microsoft requested a review from a team as a code owner September 9, 2026 21:37
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@mwiemer-microsoft

Copy link
Copy Markdown
Member Author

@RikkiGibson requesting review

@dibarbet dibarbet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While running an agent session, I triggered a 20+ minute code review. I couldn't tell what the review agent was doing, so this PR adds a status log to review sessions.

FWIW in the github copilot app I'm able to click to open the review sessions and see the live progress:

Image

so for me this would just be using extra tokens. Not strictly opposed though

Comment thread .github/skills/code-review/SKILL.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The only finding is a non-blocking nit about updates during uninterruptible commands.

Pull request overview

Adds progress-status guidance to long-running code review sessions.

Changes:

  • Adds start, phase-transition, timed, and delegated-work updates.
  • Keeps progress messages separate from final findings.
File summaries
File Summary Review finding
.github/skills/code-review/SKILL.md Documents review-session progress reporting requirements. Nit (1 vote): The five-minute guarantee may not hold during uninterruptible commands; consider heartbeats or bounded operations.
Review details

Suppressed comments (1)

.github/skills/code-review/SKILL.md:29

  • This five-minute guarantee cannot be met while the agent is blocked inside one long-running tool/command: the model cannot emit another session message until that call returns, so a 20+ minute review can still be silent despite this instruction. Please either add a session/runner heartbeat that can stream updates during waits, or change the rule to require bounded/chunked operations with updates before and after each operation rather than promising periodic updates during an uninterruptible wait.
3. If any phase or delegated work runs longer than five minutes, print a concise progress update at least every five minutes. Say what is complete, what is still running, and whether the review is blocked or proceeding.
4. Before waiting on delegated agents or long-running commands, say what is being awaited and why. When they finish, report the result before continuing.
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

Comment thread .github/skills/code-review/SKILL.md Outdated
Comment thread .github/skills/code-review/SKILL.md Outdated
Copilot AI review requested due to automatic review settings September 9, 2026 21:51
Comment thread .github/skills/code-review/SKILL.md Outdated
@mwiemer-microsoft
mwiemer-microsoft enabled auto-merge (squash) September 9, 2026 21:54
@mwiemer-microsoft
mwiemer-microsoft merged commit 571f662 into main Sep 9, 2026
3 of 5 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the Next milestone Sep 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The progress cadence is unbounded, and the repo-wide convention is not documented in the required memory conventions file.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

.github/skills/code-review/SKILL.md:26

  • This establishes a repo-wide agent behavior, but the repository’s documentation policy requires new repo-wide patterns to be added to .github/memory/CONVENTIONS.md (.github/copilot-instructions.md:97, .github/skills/update-agent-docs/SKILL.md:21). Without that entry, agents that load the memory conventions but do not select this skill will miss the progress-update requirement; please add the convention there or explain why this skill is intentionally the sole source.
### Review Progress Updates

1. Print your plan before beginning
2. After each step of your plan, print a quick result and your next step
3. Print something at least every few minutes so humans can audit activity
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread .github/skills/code-review/SKILL.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants