Make the ProjectData.Tasks package packable and include the targets file - #85232
Merged
jasonmalinowski merged 1 commit intoSep 10, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
dibarbet
approved these changes
Sep 9, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add a pack-level test verifying both support files are included under lib/netstandard2.0.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/LanguageServer/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj — Could you add a pack-level test for this change? TargetsFileShipsAlongsideTaskAssembly only… |
What changed in this PR
Enables Microsoft.NET.ProjectData.Tasks to be packaged for SDK consumption with its MSBuild support files.
Changes:
- Enables NuGet packing.
- Includes targets and schema props under
lib/netstandard2.0.
| File | Description |
|---|---|
src/LanguageServer/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj |
Configures package generation and packaged build files. |
JoeRobich
approved these changes
Sep 9, 2026
genlu
approved these changes
Sep 9, 2026
jasonmalinowski
force-pushed
the
make-projectdata.tasks-packable
branch
from
September 9, 2026 22:45
9a18544 to
ac41086
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review tier: Lite
Findings: None
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
src/LanguageServer/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj — Could you add a pack-level test for this change? TargetsFileShipsAlongsideTaskAssembly only… View resolved comment |
JoeRobich
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to enable consumption in the SDK repo.
Microsoft Reviewers: Open in CodeFlow