Correct stale Roslyn guidance references - #85211
Merged
Merged
Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: akhera99 <40616383+akhera99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update stale Roslyn guidance links in AI artifact audit
Correct stale Roslyn guidance references
Sep 8, 2026
akhera99
marked this pull request as ready for review
September 8, 2026 22:04
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly-scoped documentation clarifications and are consistent with the stated intent and the current instruction file contents.
Pull request overview
This PR updates Roslyn’s AI agent instruction docs to remove ambiguous/stale guidance and make the referenced build/file paths explicit and actionable.
Changes:
- Updates the compiler build example to point to the concrete
csc.csprojproject file instead of a directory. - Clarifies that
eng\targets\RazorServices.propsis a repo-root file (not undersrc\Razor) when registering Razor OOP services.
File summaries
| File | Description |
|---|---|
| .github/instructions/Compiler.instructions.md | Fixes the C# compiler build command to reference src/Compilers/CSharp/csc/AnyCpu/csc.csproj. |
| .github/instructions/Razor.instructions.md | Clarifies that eng\targets\RazorServices.props is a repo-root file for Razor service registration. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
333fred
reviewed
Sep 8, 2026
jasonmalinowski
approved these changes
Sep 8, 2026
Co-authored-by: akhera99 <40616383+akhera99@users.noreply.github.com>
JoeRobich
approved these changes
Sep 9, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR description/linked issue also calls for updating the compiler build example, but .github/instructions/Compiler.instructions.md still contains the stale dotnet build src/Compilers/CSharp/csc/AnyCpu/ guidance.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AI guidance contained a misleading compiler build target and an unclear Razor services file location.
eng\targets\RazorServices.propsas a repo-root file, not part ofsrc\Razor.