Fix compiler server logging - #85193
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix restores the intended behavior and includes adequate regression coverage.
Pull request overview
Restores RoslynCommandLineLogFile handling for the compiler server while preserving explicit -log: precedence.
Changes:
- Uses environment-based logging when no explicit log path is supplied.
- Adds regression tests for file, directory, and override scenarios.
File summaries
| File | Description |
|---|---|
VBCSCompiler.cs |
Restores environment-variable logging fallback. |
VBCSCompilerServerTests.cs |
Tests logging paths and precedence. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
333fred
approved these changes
Sep 8, 2026
| } | ||
|
|
||
| using var logger = new CompilerServerLogger($"VBCSCompiler {Process.GetCurrentProcess().Id}", options.LogFilePath); | ||
| using var logger = options.LogFilePath is null |
Member
There was a problem hiding this comment.
Nit: personally, I'd prefer inlining the ternary into the argument, rather than duplicating the entire constructor call, but up to you if you address this or won't fix.
Member
Author
There was a problem hiding this comment.
Well, we can't inline since it needs to call a different overload, but I should at least share the other argument expression. Thanks.
Member
Author
|
@333fred for another look, thanks |
333fred
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #84701 - automatic compiler server logging to the file/directory specified by the env var
RoslynCommandLineLogFilestopped working.Microsoft Reviewers: Open in CodeFlow