Skip Roslyn SDK VSIX preparation under Core MSBuild - #85137
Merged
Conversation
The VS SDK targets are intentionally not imported by Arcade when using Core MSBuild. Avoid requesting VSIXContainerProjectOutputGroup in unified VMR builds, while preserving desktop MSBuild behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
wtgodbe
approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a narrowly-scoped MSBuild condition update that aligns with an existing repo pattern and reduces build failures under Core MSBuild without affecting desktop MSBuild behavior.
Review tier: Lite
Findings: None
What changed in this PR
This PR adjusts the Roslyn SDK integration test project’s VSIX project-reference preparation step so it only runs when building under desktop MSBuild, avoiding invoking VSSDK-only targets when building under Core MSBuild.
Changes:
- Updated
PrepareVsixProjectReferencesto skip underMSBuildRuntimeType=Corewhile keeping existing behavior when using desktop MSBuild. - Prevents Core MSBuild builds from attempting the
VSIXContainerProjectOutputGrouptarget when VSSDK targets are not available/imported.
| File | Description |
|---|---|
| src/RoslynSdk/VisualStudio.Roslyn.SDK/Test/Roslyn.SDK.IntegrationTests/Roslyn.SDK.IntegrationTests.csproj | Gates VSIX project-reference preparation on MSBuildRuntimeType != Core to avoid VSSDK target invocation under Core MSBuild. |
JoeRobich
approved these changes
Sep 2, 2026
333fred
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unified VMR build uses Core MSBuild, where Arcade intentionally does not import
Microsoft.VsSDK.targets. The integration test project was nevertheless requestingVSIXContainerProjectOutputGroup, causing MSB4057.Validation
dotnet build .\src\RoslynSdk\VisualStudio.Roslyn.SDK\Test\Roslyn.SDK.IntegrationTests\Roslyn.SDK.IntegrationTests.csproj --no-restore -c Release -v:minimalDotNetBuildFromVMR=True,MSBuildRuntimeType=Core, andUsingToolVSSDK=trueMicrosoft Reviewers: Open in CodeFlow