Skip to content

Unsafe evolution: fix a race in version decoding #85131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
333fred merged 1 commit into from
Sep 2, 2026
+9 −11
Merged

Unsafe evolution: fix a race in version decoding #85131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEModuleSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ internal enum RefSafetyRulesAttributeVersion

private RefSafetyRulesAttributeVersion _lazyRefSafetyRulesAttributeVersion;

private MemorySafetyRulesVersion? _lazyMemorySafetyRulesVersion;
private SingleInitNullable<MemorySafetyRulesVersion> _lazyMemorySafetyRulesVersion;

#nullable enable
private DiagnosticInfo? _lazyCachedCompilerFeatureRequiredDiagnosticInfo = CSDiagnosticInfo.EmptyErrorInfo;
Expand Down Expand Up @@ -753,16 +753,14 @@ internal override MemorySafetyRulesVersion MemorySafetyRulesVersion
{
get
{
return _lazyMemorySafetyRulesVersion ??= getAttributeVersion();

// Returns
// * recognized: 1 if the attribute is not present,
// * recognized: 2 if the attribute is present and has the value 2,
// * unrecognized: -1 if the attribute is present and has the value 1 or some non-integer value,
// * unrecognized: the attribute's value (which is other than 1 or 2).
MemorySafetyRulesVersion getAttributeVersion()
return _lazyMemorySafetyRulesVersion.Initialize(static @this =>
Comment thread
jjonescz marked this conversation as resolved.
{
if (_module.HasMemorySafetyRulesAttribute(Token, out int version, out bool foundAttributeType) &&
// Returns
// * recognized: 1 if the attribute is not present,
// * recognized: 2 if the attribute is present and has the value 2,
// * unrecognized: -1 if the attribute is present and has the value 1 or some non-integer value,
// * unrecognized: the attribute's value (which is other than 1 or 2).
if (@this._module.HasMemorySafetyRulesAttribute(Token, out int version, out bool foundAttributeType) &&
version != (int)MemorySafetyRulesVersion.Version1)
{
return (MemorySafetyRulesVersion)version;
Expand All @@ -771,7 +769,7 @@ MemorySafetyRulesVersion getAttributeVersion()
return foundAttributeType
? (MemorySafetyRulesVersion)(-1)
: MemorySafetyRulesVersion.Version1;
}
}, this);
}
}

Expand Down
Loading