Prevent type rename from renaming ordinary Finalize methods - #85126
Merged
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Review tier: Lite
Findings: None
What changed in this PR
This PR fixes named type reference discovery so it only cascades to actual destructors (method kind Destructor) rather than any member named Finalize, preventing type/interface renames from incorrectly renaming ordinary Finalize methods.
Changes:
- Filter cascaded “destructor” symbols to
IMethodSymbolwithMethodKind.Destructorinstead of allFinalize-named members. - Add rename regression test ensuring a C# interface rename does not rename an ordinary
Finalizemethod. - Add find-references regression test ensuring ordinary
Finalizemethods are not treated as destructors when finding references for a named type.
| File | Description |
|---|---|
| src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finders/NamedTypeSymbolReferenceFinder.cs | Restricts destructor cascading to real destructors (by MethodKind). |
| src/EditorFeatures/Test2/Rename/RenameEngineTests.vb | Adds rename regression test covering interface + ordinary Finalize method scenario. |
| src/EditorFeatures/Test2/FindReferences/FindReferencesTests.NamedTypeSymbols.vb | Adds find-references regression test for ordinary Finalize method not being treated as a destructor. |
jasonmalinowski
approved these changes
Sep 2, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84976
Named type reference discovery treated every member named
Finalizeas a destructor. This caused renaming an interface or type to also rename an unrelated ordinaryFinalizemethod.Microsoft Reviewers: Open in CodeFlow