Skip to content

Enforce #nullable enable in source packages #85067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjonescz merged 2 commits into from
Aug 27, 2026
Merged

Enforce #nullable enable in source packages #85067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28cf2b5
Enforce `#nullable enable` in source packages
jjonescz Aug 27, 2026
5ea9a4a
Clarify
jjonescz Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eng/targets/Imports.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@
Updating a reference to this package to a newer version of the package may require changes in the referencing project.
No compatibility guarantees are provided.
</PackageDescription>
<!-- Disable project-level nullable to catch packaged files without an explicit directive;
consumers may compile them in projects where nullable is disabled. -->
<Nullable>disable</Nullable>
</PropertyGroup>

<!-- Include SourcePackage.editorconfig in all source packages. -->
Expand Down
2 changes: 2 additions & 0 deletions src/Compilers/Shared/IBuildEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#nullable enable

using System;
using System.Collections.Generic;
using System.IO;
Expand Down
2 changes: 2 additions & 0 deletions src/Compilers/Shared/StandardBuildEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#nullable enable

using System;
using System.Collections.Generic;
using System.IO;
Expand Down
2 changes: 1 addition & 1 deletion src/NuGet/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
<Import Project="$(RepositoryEngineeringDir)targets\PackageProject.props"/>
<Import Project="$(RepositoryEngineeringDir)targets\PackageProject.props" Condition="'$(IsSourcePackage)' != 'true'"/>
</Project>
2 changes: 1 addition & 1 deletion src/NuGet/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.targets', '$(MSBuildThisFileDirectory)../'))" />
<Import Project="$(RepositoryEngineeringDir)targets\PackageProject.targets" Condition="'$(TargetFramework)' != ''"/>
<Import Project="$(RepositoryEngineeringDir)targets\PackageProject.targets" Condition="'$(IsSourcePackage)' != 'true' and '$(TargetFramework)' != ''"/>
</Project>